From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936143AbdEXGiR (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 May 2017 02:38:17 -0400
Received: from mail-wm0-f54.google.com ([74.125.82.54]:34641 "EHLO
        mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932843AbdEXGiP (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 May 2017 02:38:15 -0400
Date: Wed, 24 May 2017 08:38:11 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-team@lge.com,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>, Milian Wolff <milian.wolff@kdab.com>,
        Yao Jin <yao.jin@linux.intel.com>
Subject: Re: [PATCH 4/7] perf script: Add --inline option
Message-ID: <20170524063811.onm2gder5kfks6jb@gmail.com>
References: <20170524062129.32529-1-namhyung@kernel.org>
 <20170524062129.32529-5-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170524062129.32529-5-namhyung@kernel.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Namhyung Kim <namhyung@kernel.org> wrote:

> The --inline option is to show inlined functions in callchains.
> 
> For example,
> 
>   $ perf script
>   a.out  5644 11611.467597:     309961 cycles:u:
>                      790 main (/home/namhyung/tmp/perf/a.out)
>                    20511 __libc_start_main (/usr/lib/libc-2.25.so)
>                      8ba _start (/home/namhyung/tmp/perf/a.out)
>   ...
> 
>   $ perf script --inline
>   a.out  5644 11611.467597:     309961 cycles:u:
>                      790 main (/home/namhyung/tmp/perf/a.out)
>                          std::__detail::_Adaptor<std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul>, double>::operator()
>                          std::uniform_real_distribution<double>::operator()<std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> >
>                          std::uniform_real_distribution<double>::operator()<std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> >
>                          main
>                    20511 __libc_start_main (/usr/lib/libc-2.25.so)
>                      8ba _start (/home/namhyung/tmp/perf/a.out)
>   ...

Shouldn't this be the default behavior, to make call chains more readable?

Thanks,

	Ingo