From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S938658AbdEXHNf (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 May 2017 03:13:35 -0400
Received: from LGEAMRELO11.lge.com ([156.147.23.51]:41485 "EHLO
        lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S938644AbdEXHNd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 May 2017 03:13:33 -0400
X-Original-SENDERIP: 156.147.1.151
X-Original-MAILFROM: namhyung@kernel.org
X-Original-SENDERIP: 10.177.227.17
X-Original-MAILFROM: namhyung@kernel.org
Date: Wed, 24 May 2017 16:13:30 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-team@lge.com,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>, Milian Wolff <milian.wolff@kdab.com>,
        Yao Jin <yao.jin@linux.intel.com>
Subject: Re: [PATCH 4/7] perf script: Add --inline option
Message-ID: <20170524071330.GA32206@sejong>
References: <20170524062129.32529-1-namhyung@kernel.org>
 <20170524062129.32529-5-namhyung@kernel.org>
 <20170524063811.onm2gder5kfks6jb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170524063811.onm2gder5kfks6jb@gmail.com>
User-Agent: Mutt/1.8.2 (2017-04-18)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 24, 2017 at 08:38:11AM +0200, Ingo Molnar wrote:
> 
> * Namhyung Kim <namhyung@kernel.org> wrote:
> 
> > The --inline option is to show inlined functions in callchains.
> > 
> > For example,
> > 
> >   $ perf script
> >   a.out  5644 11611.467597:     309961 cycles:u:
> >                      790 main (/home/namhyung/tmp/perf/a.out)
> >                    20511 __libc_start_main (/usr/lib/libc-2.25.so)
> >                      8ba _start (/home/namhyung/tmp/perf/a.out)
> >   ...
> > 
> >   $ perf script --inline
> >   a.out  5644 11611.467597:     309961 cycles:u:
> >                      790 main (/home/namhyung/tmp/perf/a.out)
> >                          std::__detail::_Adaptor<std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul>, double>::operator()
> >                          std::uniform_real_distribution<double>::operator()<std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> >
> >                          std::uniform_real_distribution<double>::operator()<std::linear_congruential_engine<unsigned long, 16807ul, 0ul, 2147483647ul> >
> >                          main
> >                    20511 __libc_start_main (/usr/lib/libc-2.25.so)
> >                      8ba _start (/home/namhyung/tmp/perf/a.out)
> >   ...
> 
> Shouldn't this be the default behavior, to make call chains more readable?

AFAIK perf report didn't make it default due to a performance impact,
but I didn't know how much it is.  Especially if perf was not built
with libbfd it'll run external addr2line to get inlined functions for
each callchain entry..

Thanks,
Namhyung