From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934619AbdEXK5w (ORCPT ); Wed, 24 May 2017 06:57:52 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36341 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1763633AbdEXK5X (ORCPT ); Wed, 24 May 2017 06:57:23 -0400 Date: Wed, 24 May 2017 12:57:14 +0200 From: Heiko Carstens To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Sebastian Siewior , Paul McKenney , linux-s390@vger.kernel.org, David Hildenbrand , Martin Schwidefsky Subject: Re: [patch V3 15/32] s390/kernel: Use stop_machine_cpuslocked() References: <20170524081511.203800767@linutronix.de> <20170524081548.250203087@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170524081548.250203087@linutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 17052410-0012-0000-0000-000005385CC7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17052410-0013-0000-0000-0000189A4317 Message-Id: <20170524105714.GD5427@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-24_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705240053 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 24, 2017 at 10:15:26AM +0200, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior > > stp_work_fn() holds get_online_cpus() while invoking stop_machine(). > > stop_machine() invokes get_online_cpus() as well. This is correct, but > prevents the conversion of the hotplug locking to a percpu rwsem. > > Use stop_machine_cpuslocked() to avoid the nested call. Convert > *_online_cpus() to the new interfaces while at it. > > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: linux-s390@vger.kernel.org > Cc: Peter Zijlstra > Cc: Heiko Carstens > Cc: Steven Rostedt > Cc: David Hildenbrand > Cc: Martin Schwidefsky > > --- > arch/s390/kernel/time.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Acked-by: Heiko Carstens