From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161364AbdEXMDn (ORCPT ); Wed, 24 May 2017 08:03:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:43646 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1032421AbdEXMDW (ORCPT ); Wed, 24 May 2017 08:03:22 -0400 Date: Wed, 24 May 2017 14:03:18 +0200 From: Michal Hocko To: Wei Yang Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] refine and rename slub sysfs Message-ID: <20170524120318.GE14733@dhcp22.suse.cz> References: <20170517141146.11063-1-richard.weiyang@gmail.com> <20170518090636.GA25471@dhcp22.suse.cz> <20170523032705.GA4275@WeideMBP.lan> <20170523063911.GC12813@dhcp22.suse.cz> <20170524095450.GA7706@WeideMBP.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170524095450.GA7706@WeideMBP.lan> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 24-05-17 17:54:50, Wei Yang wrote: > On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote: [...] > >Is this worth risking breakage of the userspace which consume this data > >now? Do you have any user space code which will greatly benefit from the > >new data and which couldn't do the same with the current format/output? > > > >If yes this all should be in the changelog. > > The answer is no. > > I have the same concern as yours. So this patch set could be divided into two > parts: 1. add some new entry with current name convention, 2. change the name > convention. Who is going to use those new entries and for what purpose? Why do we want to expose even more details of the slab allocator to the userspace. Is the missing information something fundamental that some user space cannot work without it? Seriously these are essential questions you should have answer for _before_ posting the patch and mention all those reasons in the changelog. -- Michal Hocko SUSE Labs