From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940350AbdEXT1m (ORCPT ); Wed, 24 May 2017 15:27:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:39110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937592AbdEXT1j (ORCPT ); Wed, 24 May 2017 15:27:39 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C56C238FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Wed, 24 May 2017 20:27:35 +0100 From: Jonathan Cameron To: Nikita Yushchenko Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Sanchayan Maity , Gregor Boirie , Matt Ranostay , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Healy , Jeff White , Vladimir Barinov Subject: Re: [PATCH/RFC] iio: hi8435: do not enable all events by default Message-ID: <20170524202735.3cf4e14e@kernel.org> In-Reply-To: <20170523080830.20571-1-nikita.yoush@cogentembedded.com> References: <20170523080830.20571-1-nikita.yoush@cogentembedded.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2017 11:08:30 +0300 Nikita Yushchenko wrote: > Having all events enabled by default is misleading. > Userspace should explicitly enable events they want to receive. > > Signed-off-by: Nikita Yushchenko I agree in principle, but this is a userspace ABI change. Sadly we can't do it with out risking breaking userspace code... One of those we should have caught in review, but now it's there we can't actually do anything about it unless we are absolutely sure no one will notice! Jonathan > --- > drivers/iio/adc/hi8435.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c > index ef5c286c8e67..0331739f235c 100644 > --- a/drivers/iio/adc/hi8435.c > +++ b/drivers/iio/adc/hi8435.c > @@ -506,8 +506,6 @@ static int hi8435_probe(struct spi_device *spi) > idev->channels = hi8435_channels; > idev->num_channels = ARRAY_SIZE(hi8435_channels); > > - /* unmask all events */ > - priv->event_scan_mask = ~(0); > /* > * There is a restriction in the chip - the hysteresis can not be odd. > * If the hysteresis is set to odd value then chip gets into lock state