From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940959AbdEXT27 (ORCPT ); Wed, 24 May 2017 15:28:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:39328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940867AbdEXT25 (ORCPT ); Wed, 24 May 2017 15:28:57 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A5F8238FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Wed, 24 May 2017 20:28:53 +0100 From: Jonathan Cameron To: Nikita Yushchenko Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Sanchayan Maity , Gregor Boirie , Matt Ranostay , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Healy , Jeff White , Vladimir Barinov Subject: Re: [PATCH] iio: hi8435: remote ampersands from hi8435_info definition Message-ID: <20170524202853.0cfc4c1e@kernel.org> In-Reply-To: <20170523080746.20512-1-nikita.yoush@cogentembedded.com> References: <20170523080746.20512-1-nikita.yoush@cogentembedded.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2017 11:07:46 +0300 Nikita Yushchenko wrote: > C syntax allows apersands when initializing structures fields with > function pointers, but in Linux sources ampersands are normally not used > in thix context. > > Signed-off-by: Nikita Yushchenko Applied to the togreg branch of iio.git and pushed out as testing. Thanks, Jonathan > --- > drivers/iio/adc/hi8435.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/hi8435.c b/drivers/iio/adc/hi8435.c > index 28fc699f00f6..ef5c286c8e67 100644 > --- a/drivers/iio/adc/hi8435.c > +++ b/drivers/iio/adc/hi8435.c > @@ -414,11 +414,11 @@ static const struct iio_chan_spec hi8435_channels[] = { > static const struct iio_info hi8435_info = { > .driver_module = THIS_MODULE, > .read_raw = hi8435_read_raw, > - .read_event_config = &hi8435_read_event_config, > + .read_event_config = hi8435_read_event_config, > .write_event_config = hi8435_write_event_config, > - .read_event_value = &hi8435_read_event_value, > - .write_event_value = &hi8435_write_event_value, > - .debugfs_reg_access = &hi8435_debugfs_reg_access, > + .read_event_value = hi8435_read_event_value, > + .write_event_value = hi8435_write_event_value, > + .debugfs_reg_access = hi8435_debugfs_reg_access, > }; > > static void hi8435_iio_push_event(struct iio_dev *idev, unsigned int val)