From: "Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>
To: David Howells <dhowells@redhat.com>
Cc: linux-cachefs@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type
Date: Sat, 27 May 2017 20:31:04 -0400 [thread overview]
Message-ID: <20170527203104.077c0a8a@blatinox-laptop.localdomain> (raw)
In-Reply-To: <28723.1493305425@warthog.procyon.org.uk>
On Thu, 27 Apr 2017 16:03:45 +0100
David Howells <dhowells@redhat.com> wrote:
> Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> wrote:
>
> > When building object-list.o, gcc 6 raises a warning on the sprintf call
> > in fscache_objlist_show:
> >
> > CC fs/fscache/object-list.o
> > fs/fscache/object-list.c: In function ‘fscache_objlist_show’:
> > fs/fscache/object-list.c:265:19: warning: ‘sprintf’ may write a
> > terminating nul past the end of the destination [-Wformat-overflow=]
> > sprintf(_type, "%02u", cookie->def->type);
> > ^~~~~~
> > fs/fscache/object-list.c:265:4: note: ‘sprintf’ output between 3 and 4
> > bytes into a destination of size 3
> > sprintf(_type, "%02u", cookie->def->type);
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Moreover, the documentation says that we should have an hex value for
> > special cookies (see Documentation/filesystems/caching/fscache.txt).
> >
> > Printing hexadecimal value for special cookies fixes the overflow
> > warning and complies with the documentation.
>
> Fine by me. We don't actually handle special type cookies at the moment, so
> you're not going to see anything other than DT or IX for now anyway.
>
> I'll push this in the next merge window if that's okay with you.
>
Hi David,
I didn't clearly say that I'm okay about pushing this patch in my last
answer. I am okay with that.
I don't see this patch in v4.12-rc2. Is there an issue with this patch
or are you waiting for my answer ?
Thanks,
Jérémy
prev parent reply other threads:[~2017-05-28 0:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 20:38 [PATCH] FS-Cache: print hexadecimal value for special cookies type Jérémy Lefaure
2017-04-21 19:41 ` Andy Shevchenko
2017-04-21 23:09 ` Jérémy Lefaure
2017-04-24 21:47 ` Andy Shevchenko
2017-04-25 21:37 ` Jérémy Lefaure
2017-04-25 22:04 ` Andy Shevchenko
2017-04-27 0:31 ` [PATCH v2] FS-Cache: fix buffer size for decimal value of special cookie type Jérémy Lefaure
2017-04-27 15:03 ` [PATCH] FS-Cache: print hexadecimal value for special cookies type David Howells
2017-04-27 15:11 ` Jérémy Lefaure
2017-04-27 15:41 ` David Howells
2017-05-28 0:31 ` Jérémy Lefaure [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170527203104.077c0a8a@blatinox-laptop.localdomain \
--to=jeremy.lefaure@lse.epita.fr \
--cc=dhowells@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).