From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750825AbdE1AbK convert rfc822-to-8bit (ORCPT ); Sat, 27 May 2017 20:31:10 -0400 Received: from blatinox.fr ([51.254.120.209]:55632 "EHLO vps202351.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbdE1AbJ (ORCPT ); Sat, 27 May 2017 20:31:09 -0400 Date: Sat, 27 May 2017 20:31:04 -0400 From: =?UTF-8?B?SsOpcsOpbXk=?= Lefaure To: David Howells Cc: linux-cachefs@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type Message-ID: <20170527203104.077c0a8a@blatinox-laptop.localdomain> In-Reply-To: <28723.1493305425@warthog.procyon.org.uk> References: <20170419203819.21951-1-jeremy.lefaure@lse.epita.fr> <28723.1493305425@warthog.procyon.org.uk> X-Mailer: Claws Mail 3.14.1-18-ga4ef8a-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Apr 2017 16:03:45 +0100 David Howells wrote: > Jérémy Lefaure wrote: > > > When building object-list.o, gcc 6 raises a warning on the sprintf call > > in fscache_objlist_show: > > > > CC fs/fscache/object-list.o > > fs/fscache/object-list.c: In function ‘fscache_objlist_show’: > > fs/fscache/object-list.c:265:19: warning: ‘sprintf’ may write a > > terminating nul past the end of the destination [-Wformat-overflow=] > > sprintf(_type, "%02u", cookie->def->type); > > ^~~~~~ > > fs/fscache/object-list.c:265:4: note: ‘sprintf’ output between 3 and 4 > > bytes into a destination of size 3 > > sprintf(_type, "%02u", cookie->def->type); > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > Moreover, the documentation says that we should have an hex value for > > special cookies (see Documentation/filesystems/caching/fscache.txt). > > > > Printing hexadecimal value for special cookies fixes the overflow > > warning and complies with the documentation. > > Fine by me. We don't actually handle special type cookies at the moment, so > you're not going to see anything other than DT or IX for now anyway. > > I'll push this in the next merge window if that's okay with you. > Hi David, I didn't clearly say that I'm okay about pushing this patch in my last answer. I am okay with that. I don't see this patch in v4.12-rc2. Is there an issue with this patch or are you waiting for my answer ? Thanks, Jérémy