From: Jonathan Cameron <jic23@kernel.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Sanchayan Maity <maitysanchayan@gmail.com>,
Gregor Boirie <gregor.boirie@parrot.com>,
Matt Ranostay <mranostay@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Chris Healy <Chris.Healy@zii.aero>,
Jeff White <Jeff.White@zii.aero>,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Subject: Re: [PATCH/RFC] iio: hi8435: do not enable all events by default
Date: Sun, 28 May 2017 16:48:46 +0100 [thread overview]
Message-ID: <20170528164846.3fa3d4d8@kernel.org> (raw)
In-Reply-To: <2e6019f5-94fc-bb13-f616-0c1cfe81a7db@cogentembedded.com>
On Thu, 25 May 2017 08:47:47 +0300
Nikita Yushchenko <nikita.yoush@cogentembedded.com> wrote:
> 24.05.2017 22:27, Jonathan Cameron wrote:
> > On Tue, 23 May 2017 11:08:30 +0300
> > Nikita Yushchenko <nikita.yoush@cogentembedded.com> wrote:
> >
> >> Having all events enabled by default is misleading.
> >> Userspace should explicitly enable events they want to receive.
> >>
> >> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> > I agree in principle, but this is a userspace ABI change. Sadly we
> > can't do it with out risking breaking userspace code...
> >
> > One of those we should have caught in review, but now it's there
> > we can't actually do anything about it unless we are absolutely
> > sure no one will notice!
>
> I see your point.
>
> Still, isn't there subsystem-level default that all events are disabled
> by default? If such, then current hi8435 state breaks subsystem-level
> rules, which is a [userspace-visible] bug. I'm not sure how far should
> we go in bug compatibility.
It is indeed the subsystem default (as much as we have one)
This is a moderately obscure chip for linux systems, do we have a good handle
on where it is being used - i.e. are most of the devices under control of
people we can discuss this with?
>
> One crazy idea could be - make default selectable via device tree (with
> default set to all-enabled to keep bug-compatibility). But perhaps
> that's over-reaction.
Yeah, wouldn't fly with the devicetree binding maintainers..
Jonathan
next prev parent reply other threads:[~2017-05-28 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 8:08 [PATCH/RFC] iio: hi8435: do not enable all events by default Nikita Yushchenko
2017-05-24 19:27 ` Jonathan Cameron
2017-05-25 5:47 ` Nikita Yushchenko
2017-05-28 15:48 ` Jonathan Cameron [this message]
[not found] ` <CY4PR12MB12549ADA207663849E8DBE8583F20@CY4PR12MB1254.namprd12.prod.outlook.com>
2017-05-28 17:00 ` Fw: " Chris Healy
2017-05-29 5:40 ` Nikita Yushchenko
2017-06-03 9:07 ` Jonathan Cameron
2017-06-09 9:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170528164846.3fa3d4d8@kernel.org \
--to=jic23@kernel.org \
--cc=Chris.Healy@zii.aero \
--cc=Jeff.White@zii.aero \
--cc=gregor.boirie@parrot.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=mranostay@gmail.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=pmeerw@pmeerw.net \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).