From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Nick Desaulniers <nick.desaulniers@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Input: mousedev - fix implicit conversion warning
Date: Mon, 29 May 2017 19:44:13 -0700 [thread overview]
Message-ID: <20170530024413.GB32841@dtor-ws> (raw)
In-Reply-To: <20170529192252.jv6wpuzaouykqqgy@lostoracle.net>
On Mon, May 29, 2017 at 12:22:52PM -0700, Nick Desaulniers wrote:
> On Fri, May 26, 2017 at 10:07:46AM -0700, Dmitry Torokhov wrote:
> > If you look at the code of this fucntion we really use ps2_data as
> > signed in calculations, and this change would break that. While making
> > ps2_data u8 might be beneficial we'd need to rework mousedev_packet() to
> > use signed temporaries for dx, dy and dz before stufifng them into
> > ps2_data.
>
> Is your recommendation then to stick with the simple cast as in V1 of
> this patch, or stick with u8 and rework mousedev_packet()?
I think casts are often mysterious, so, unless we'll end up with worse
object code, I'd switch to u8 and temps.
--
Dmitry
next prev parent reply other threads:[~2017-05-30 2:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 5:22 [PATCH] Input: mousedev - fix implicit conversion warning Nick Desaulniers
2017-05-26 15:34 ` [PATCH v2] " Nick Desaulniers
2017-05-26 15:40 ` [PATCH v3] " Nick Desaulniers
2017-05-26 17:07 ` Dmitry Torokhov
2017-05-29 19:22 ` Nick Desaulniers
2017-05-30 2:44 ` Dmitry Torokhov [this message]
2017-05-30 5:41 ` [PATCH v4] " Nick Desaulniers
2017-06-06 16:18 ` Nick Desaulniers
2017-06-23 4:16 ` Nick Desaulniers
2017-06-25 18:06 ` Dmitry Torokhov
2017-06-27 1:39 ` Nick Desaulniers
2017-07-12 6:57 ` Nick Desaulniers
2017-07-12 18:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530024413.GB32841@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick.desaulniers@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).