From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751071AbdE3Jin (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 05:38:43 -0400
Received: from foss.arm.com ([217.140.101.70]:56092 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750911AbdE3Jij (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 05:38:39 -0400
Date: Tue, 30 May 2017 10:38:43 +0100
From: Will Deacon <will.deacon@arm.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        Miroslav Lichvar <mlichvar@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Prarit Bhargava <prarit@redhat.com>,
        Stephen Boyd <stephen.boyd@linaro.org>,
        Kevin Brodsky <kevin.brodsky@arm.com>,
        Daniel Mentz <danielmentz@google.com>
Subject: Re: [RFC][PATCH 3/4] arm64: vdso: Fix nsec handling for
 CLOCK_MONOTONIC_RAW
Message-ID: <20170530093842.GA32289@arm.com>
References: <1495856035-6622-1-git-send-email-john.stultz@linaro.org>
 <1495856035-6622-4-git-send-email-john.stultz@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1495856035-6622-4-git-send-email-john.stultz@linaro.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 26, 2017 at 08:33:54PM -0700, John Stultz wrote:
> From: Will Deacon <will.deacon@arm.com>
> 
> Commit 45a7905fc48f ("arm64: vdso: defer shifting of nanosecond
> component of timespec") fixed sub-ns inaccuracies in our vDSO
> clock_gettime implementation by deferring the right-shift of the
> nanoseconds components until after the timespec addition, which
> operates on left-shifted values. That worked nicely until
> support for CLOCK_MONOTONIC_RAW was added in 49eea433b326
> ("arm64: Add support for CLOCK_MONOTONIC_RAW in clock_gettime()
> vDSO"). Noticing that the core timekeeping code never set
> tkr_raw.xtime_nsec, the vDSO implementation didn't bother
> exposing it via the data page and instead took the unshifted
> tk->raw_time.tv_nsec value which was then immediately shifted
> left in the vDSO code.
> 
> Now that the core code is actually setting tkr_raw.xtime_nsec,
> we need to take that into account in the vDSO by adding it to
> the shifted raw_time value. Rather than do that at each use (and
> expand the data page in the process), instead perform the
> shift/addition operation when populating the data page and
> remove the shift from the vDSO code entirely.
> 
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Miroslav Lichvar <mlichvar@redhat.com>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Prarit Bhargava <prarit@redhat.com>
> Cc: Stephen Boyd <stephen.boyd@linaro.org>
> Cc: Kevin Brodsky <kevin.brodsky@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Daniel Mentz <danielmentz@google.com>
> Reported-by: John Stultz <john.stultz@linaro.org>
> Acked-by: Acked-by: Kevin Brodsky <kevin.brodsky@arm.com>

I don't think Kevin liked it *that* much ^^

Will