From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751135AbdE3Bdo (ORCPT ); Mon, 29 May 2017 21:33:44 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36825 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbdE3Bdn (ORCPT ); Mon, 29 May 2017 21:33:43 -0400 Date: Tue, 30 May 2017 11:33:32 +1000 From: Balbir Singh To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Scott Wood , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/7] powerpc/mm: rename map_page() to map_kernel_page() on PPC32 Message-ID: <20170530113332.763d10ac@firefly.ozlabs.ibm.com> In-Reply-To: <83aadb3163da87ec017ca4a61afcc29520a27eff.1496070452.git.christophe.leroy@c-s.fr> References: <83aadb3163da87ec017ca4a61afcc29520a27eff.1496070452.git.christophe.leroy@c-s.fr> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 May 2017 17:31:56 +0200 (CEST) Christophe Leroy wrote: > Signed-off-by: Christophe Leroy > --- ... > diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c > index de5a90e1ceaa..8e9bef964dbf 100644 > --- a/arch/powerpc/mm/mem.c > +++ b/arch/powerpc/mm/mem.c > @@ -305,11 +305,11 @@ void __init paging_init(void) > unsigned long end = __fix_to_virt(FIX_HOLE); > > for (; v < end; v += PAGE_SIZE) > - map_page(v, 0, 0); /* XXX gross */ > + map_kernel_page(v, 0, 0); /* XXX gross */ What is 0, 0? Everything maps to physical address 0 with 0 permissions? Thanks for doing this Acked-by: Balbir Singh Balbir