From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751081AbdE3RCB (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 13:02:01 -0400
Received: from merlin.infradead.org ([205.233.59.134]:51120 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750733AbdE3RCA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 13:02:00 -0400
Date: Tue, 30 May 2017 19:01:50 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Vince Weaver <vince@deater.net>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>
Subject: Re: perf group read for inherited events
Message-ID: <20170530170150.cx554x7nmbrzv7nc@hirez.programming.kicks-ass.net>
References: <20170526205601.GA5271@tassilo.jf.intel.com>
 <20170530094512.dy2nljns2uq7qa3j@hirez.programming.kicks-ass.net>
 <20170530135714.GJ24144@tassilo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170530135714.GJ24144@tassilo.jf.intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 30, 2017 at 06:57:14AM -0700, Andi Kleen wrote:
> On Tue, May 30, 2017 at 11:45:12AM +0200, Peter Zijlstra wrote:
> > > Or is the simple patch below good enough?
> > 
> > The below seems to be the correct thing. It is rather unfortunate that
> > this would break/significantly change existing semantics :/
> 
> The "existing semantics" as in ignoring the PERF_SAMPLE_READ in sample_type,
> even though it wasn't implemented? It seems reasonable to me.

Right, so where we used to accept PERF_SAMPLE_READ on inherited events,
we now no longer will.

Note that it currently doesn't work right, even if it doesn't fail like
with the proposed patch.

Typically Vince will (rightly) complain when I change things like this.
But seeing how even if we accept it, it is fairly terminally buggered in
any case, we could change it.

Vince, do you know of anybody that would be immediately affected by
this?