From: Guenter Roeck <linux@roeck-us.net>
To: Joel Stanley <joel@jms.id.au>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>
Subject: Re: [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP
Date: Tue, 30 May 2017 15:09:51 -0700 [thread overview]
Message-ID: <20170530220951.GA9139@roeck-us.net> (raw)
In-Reply-To: <CACPK8XdMask2f_Ewoo54+FPAjPbGJMxp2E5YeJHC-r-aokPkCg@mail.gmail.com>
On Tue, May 30, 2017 at 03:48:22PM +0930, Joel Stanley wrote:
> On Sat, May 27, 2017 at 11:24 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> > The driver uses regmap and thus has to select it to avoid build
> > errors such as the following.
> >
> > drivers/hwmon/aspeed-pwm-tacho.c:337:21: error: variable
> > 'aspeed_pwm_tacho_regmap_config' has initializer but incomplete type
>
> While we're at it the driver should also depend on OF.
>
The driver compiles without it, so that isn't strictly necessary.
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Acked-by: Joel Stanley <joel@jms.id.au>
>
Thanks,
Guenter
> Cheers,
>
> Joel
>
>
> > ---
> > drivers/hwmon/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > index 22d5eafd6815..5ef2814345ef 100644
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -343,6 +343,7 @@ config SENSORS_ASB100
> >
> > config SENSORS_ASPEED
> > tristate "ASPEED AST2400/AST2500 PWM and Fan tach driver"
> > + select REGMAP
> > help
> > This driver provides support for ASPEED AST2400/AST2500 PWM
> > and Fan Tacho controllers.
> > --
> > 2.7.4
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-05-30 22:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 13:54 [PATCH] hwmon: (aspeed-pwm-tacho) Select REGMAP Guenter Roeck
2017-05-30 6:18 ` Joel Stanley
2017-05-30 22:09 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530220951.GA9139@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jaghu@google.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).