From: Pavel Machek <pavel@ucw.cz>
To: fenglinw@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
subbaram@quicinc.com, aghayal@qti.qualcomm.com,
wruan@quicinc.com, kgunda@qti.qualcomm.com
Subject: Re: [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module
Date: Wed, 31 May 2017 09:55:36 +0200 [thread overview]
Message-ID: <20170531075536.GA13028@amd> (raw)
In-Reply-To: <20170531061541.10808-2-fenglinw@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]
Hi!
> +- qcom,support-blink:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: An array of integer values to indicate if "blue", "green", "red"
> + LEDs support blink control. The values are listed as the fixed
> + order for "blue", "green", "red" LEDs.
Normal order is RGB, and no need for the "s.
> +- qcom,on-ms:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: An array of time values (milli-seconds) to represent the
> + on duration for "blue", "green", "red" LEDs. The values are
> + listed as the fixed order for "blue", "green", "red" LEDs.
> + This property has to be defined if "qcom,support-blink" is
> + present.
> +
> +- qcom,off-ms:
> + Usage: optional
> + Value type: <prop-encoded-array>
> + Definition: An array of time values (milli-seconds) to represent the
> + off duration for "blue", "green", "red" LEDs. The values are
> + listed as the fixed order for "blue", "green", "red" LEDs.
> + This property has to be defined if "qcom,support-blink" is
> + present.
I don't get it; why is this needed?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-05-31 7:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 6:14 [PATCH V1 0/2] *** Add support for QTI TRI_LED and LPG module *** fenglinw
2017-05-31 6:14 ` [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module fenglinw
2017-05-31 7:55 ` Pavel Machek [this message]
2017-05-31 8:23 ` Wu Fenglin
2017-05-31 16:55 ` Pavel Machek
2017-06-01 0:30 ` Wu Fenglin
2017-06-01 19:31 ` Jacek Anaszewski
2017-05-31 6:14 ` [PATCH V1 2/2] pwm: pwm-qti-lpg: Add PWM driver for QTI LPG module fenglinw
2017-06-03 23:20 ` kbuild test robot
2017-06-07 21:19 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531075536.GA13028@amd \
--to=pavel@ucw.cz \
--cc=aghayal@qti.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=fenglinw@codeaurora.org \
--cc=jacek.anaszewski@gmail.com \
--cc=kgunda@qti.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=subbaram@quicinc.com \
--cc=wruan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).