> + data->types ? data->types : NULL, This is equal to just 'data_types'. > + NULL, > + data->partitions ? > + data->partitions : NULL, > + data->nr_partitions ? > + data->nr_partitions : 0); All the ternary operators are superfluous.