From: Wolfram Sang <wsa@the-dreams.de>
To: Andrea Adami <andrea.adami@gmail.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Lee Jones <lee.jones@linaro.org>, Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Linus Walleij <linus.walleij@linaro.org>,
Russell King <linux@armlinux.org.uk>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/9] mtd: nand: tmio_nand.c: take in account partition parser types
Date: Thu, 1 Jun 2017 10:37:49 +0200 [thread overview]
Message-ID: <20170601083749.GC1477@katana> (raw)
In-Reply-To: <1496270458-6479-6-git-send-email-andrea.adami@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
> - retval = mtd_device_parse_register(mtd, NULL, NULL,
> + retval = mtd_device_parse_register(mtd,
> + data->types ? data->types : NULL,
This is superfluous. You want to check against 'data' instead as it is
done below. Otherwis you might get a NULL pointer dereference.
> + NULL,
> data ? data->partition : NULL,
> data ? data->num_partitions : 0);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-06-01 8:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 22:40 [PATCH v3 0/9] mtd: sharpslpart partition parser Andrea Adami
2017-05-31 22:40 ` [PATCH v3 1/9] mtd: sharpslpart: add sharpslpart MTD " Andrea Adami
2017-06-09 1:30 ` Brian Norris
2017-06-20 8:52 ` Andrea Adami
2017-06-20 22:05 ` Brian Norris
2017-06-09 1:42 ` Brian Norris
2017-06-20 8:56 ` Andrea Adami
2017-05-31 22:40 ` [PATCH v3 2/9] mtd: nand: sharpsl.h: support partition parser types Andrea Adami
2017-05-31 22:40 ` [PATCH v3 3/9] mfd: tmio.h: " Andrea Adami
2017-06-01 8:40 ` Wolfram Sang
2017-06-01 14:35 ` Lee Jones
2017-06-03 21:40 ` Andrea Adami
2017-06-05 7:59 ` Lee Jones
2017-05-31 22:40 ` [PATCH v3 4/9] mtd: nand: sharpsl.c: take in account " Andrea Adami
2017-06-01 8:35 ` Wolfram Sang
2017-05-31 22:40 ` [PATCH v3 5/9] mtd: nand: tmio_nand.c: " Andrea Adami
2017-06-01 8:37 ` Wolfram Sang [this message]
2017-05-31 22:40 ` [PATCH v3 6/9] arm: pxa: corgi.c: remove hardcoded partitioning, use sharpslpart parser Andrea Adami
2017-05-31 22:40 ` [PATCH v3 7/9] arm: pxa: tosa.c: " Andrea Adami
2017-05-31 22:40 ` [PATCH v3 8/9] arm: pxa: spitz.c: " Andrea Adami
2017-05-31 22:40 ` [PATCH v3 9/9] arm: pxa: poodle.c: " Andrea Adami
2017-06-09 1:35 ` [PATCH v3 0/9] mtd: sharpslpart partition parser Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601083749.GC1477@katana \
--to=wsa@the-dreams.de \
--cc=andrea.adami@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=daniel@zonque.org \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=haojian.zhuang@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=robert.jarzmik@free.fr \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).