From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751245AbdFANKN (ORCPT ); Thu, 1 Jun 2017 09:10:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60270 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbdFANKL (ORCPT ); Thu, 1 Jun 2017 09:10:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BDB7CC04B956 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com BDB7CC04B956 Date: Thu, 1 Jun 2017 15:10:07 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern Subject: Re: [PATCH] perf test: Disable breakpoint signal tests for powerpc Message-ID: <20170601131007.GA27070@krava> References: <20170516174942.13650-1-jolsa@kernel.org> <20170601130458.GB2899@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170601130458.GB2899@kernel.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 01 Jun 2017 13:10:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 01, 2017 at 10:04:58AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, May 16, 2017 at 07:49:42PM +0200, Jiri Olsa escreveu: > > Following tests are constantly failing on powerpc: > > > > # perf test break > > 18: Breakpoint overflow signal handler : FAILED! > > 19: Breakpoint overflow sampling : FAILED! > > > > The powerpc so far does not have support to even create > > instruction breakpoint using the perf event interface, > > so those tests fail early in the config phase. > > > > I added 'ison' callback to test struct to be able to > > disable specific test. It seems better than putting > > ifdefs directly to the test array. > > > > Link: http://lkml.kernel.org/n/tip-erwshbq6f7b7hdtu65z5a25y@git.kernel.org > > Signed-off-by: Jiri Olsa > > --- > > tools/perf/tests/bp_signal.c | 14 ++++++++++++++ > > tools/perf/tests/builtin-test.c | 7 +++++++ > > tools/perf/tests/tests.h | 3 +++ > > 3 files changed, 24 insertions(+) > > > > diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c > > index e7664fe3bd33..0467c3b6d849 100644 > > --- a/tools/perf/tests/bp_signal.c > > +++ b/tools/perf/tests/bp_signal.c > > @@ -288,3 +288,17 @@ int test__bp_signal(int subtest __maybe_unused) > > return count1 == 1 && overflows == 3 && count2 == 3 && overflows_2 == 3 && count3 == 2 ? > > TEST_OK : TEST_FAIL; > > } > > + > > +bool test__bp_signal_is_on(void) > > Can you please rename this "_is_on()" thing to "_supported()"? ok jirka