From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH] perf trace: Add mmap alias for s390
Date: Thu, 1 Jun 2017 10:13:10 -0300 [thread overview]
Message-ID: <20170601131310.GE2899@kernel.org> (raw)
In-Reply-To: <20170531113557.19175-1-jolsa@kernel.org>
Em Wed, May 31, 2017 at 01:35:57PM +0200, Jiri Olsa escreveu:
> The s390 architecture maps sys_mmap (nr 90) into sys_old_mmap.
> For this reason perf trace can't find the proper syscall event
> to get args format from and displays it wrong as 'continued'.
>
> To fix that fill "alias" field with "old_mmap" for trace's mmap
> record to get the correct translation.
Ok, I'll add this, but at some point we'll need to do this by looking at
the perf.data header when cross-tracing on a non-live, perf.data based
setup.
- Arnaldo
> Before:
> 0.042 ( 0.011 ms): vest/43052 fstat(statbuf: 0x3ffff89fd90 ) = 0
> 0.042 ( 0.028 ms): vest/43052 ... [continued]: mmap()) = 0x3fffd6e2000
> 0.072 ( 0.025 ms): vest/43052 read(buf: 0x3fffd6e2000, count: 4096 ) = 6
>
> After:
> 0.045 ( 0.011 ms): fstat(statbuf: 0x3ffff8a0930 ) = 0
> 0.057 ( 0.018 ms): mmap(arg: 0x3ffff8a0858 ) = 0x3fffd14a000
> 0.076 ( 0.025 ms): read(buf: 0x3fffd14a000, count: 4096 ) = 6
>
> Link: http://lkml.kernel.org/n/tip-3jrfsbpclxr1ftke2t9rpvy6@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/builtin-trace.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index d014350adc52..4b2a5d298197 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -681,6 +681,10 @@ static struct syscall_fmt {
> { .name = "mlockall", .errmsg = true,
> .arg_scnprintf = { [0] = SCA_HEX, /* addr */ }, },
> { .name = "mmap", .hexret = true,
> +/* The standard mmap maps to old_mmap on s390x */
> +#if defined(__s390x__)
> + .alias = "old_mmap",
> +#endif
> .arg_scnprintf = { [0] = SCA_HEX, /* addr */
> [2] = SCA_MMAP_PROT, /* prot */
> [3] = SCA_MMAP_FLAGS, /* flags */ }, },
> --
> 2.9.4
next prev parent reply other threads:[~2017-06-01 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 11:35 [PATCH] perf trace: Add mmap alias for s390 Jiri Olsa
2017-06-01 13:13 ` Arnaldo Carvalho de Melo [this message]
2017-06-07 15:56 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601131310.GE2899@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).