From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751285AbdFANNP (ORCPT ); Thu, 1 Jun 2017 09:13:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:32860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbdFANNN (ORCPT ); Thu, 1 Jun 2017 09:13:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69011239EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 1 Jun 2017 10:13:10 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern Subject: Re: [PATCH] perf trace: Add mmap alias for s390 Message-ID: <20170601131310.GE2899@kernel.org> References: <20170531113557.19175-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170531113557.19175-1-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, May 31, 2017 at 01:35:57PM +0200, Jiri Olsa escreveu: > The s390 architecture maps sys_mmap (nr 90) into sys_old_mmap. > For this reason perf trace can't find the proper syscall event > to get args format from and displays it wrong as 'continued'. > > To fix that fill "alias" field with "old_mmap" for trace's mmap > record to get the correct translation. Ok, I'll add this, but at some point we'll need to do this by looking at the perf.data header when cross-tracing on a non-live, perf.data based setup. - Arnaldo > Before: > 0.042 ( 0.011 ms): vest/43052 fstat(statbuf: 0x3ffff89fd90 ) = 0 > 0.042 ( 0.028 ms): vest/43052 ... [continued]: mmap()) = 0x3fffd6e2000 > 0.072 ( 0.025 ms): vest/43052 read(buf: 0x3fffd6e2000, count: 4096 ) = 6 > > After: > 0.045 ( 0.011 ms): fstat(statbuf: 0x3ffff8a0930 ) = 0 > 0.057 ( 0.018 ms): mmap(arg: 0x3ffff8a0858 ) = 0x3fffd14a000 > 0.076 ( 0.025 ms): read(buf: 0x3fffd14a000, count: 4096 ) = 6 > > Link: http://lkml.kernel.org/n/tip-3jrfsbpclxr1ftke2t9rpvy6@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/builtin-trace.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c > index d014350adc52..4b2a5d298197 100644 > --- a/tools/perf/builtin-trace.c > +++ b/tools/perf/builtin-trace.c > @@ -681,6 +681,10 @@ static struct syscall_fmt { > { .name = "mlockall", .errmsg = true, > .arg_scnprintf = { [0] = SCA_HEX, /* addr */ }, }, > { .name = "mmap", .hexret = true, > +/* The standard mmap maps to old_mmap on s390x */ > +#if defined(__s390x__) > + .alias = "old_mmap", > +#endif > .arg_scnprintf = { [0] = SCA_HEX, /* addr */ > [2] = SCA_MMAP_PROT, /* prot */ > [3] = SCA_MMAP_FLAGS, /* flags */ }, }, > -- > 2.9.4