From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751150AbdFBC43 (ORCPT ); Thu, 1 Jun 2017 22:56:29 -0400 Received: from mga14.intel.com ([192.55.52.115]:9829 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122AbdFBC42 (ORCPT ); Thu, 1 Jun 2017 22:56:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,283,1493708400"; d="asc'?scan'208";a="975842964" Date: Fri, 2 Jun 2017 10:52:24 +0800 From: "Du, Changbin" To: Jiri Olsa Cc: changbin.du@intel.com, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf sort: only insert overhead && overhead_children when no overhead* field given Message-ID: <20170602025223.GA9307@intel.com> References: <1496307801-24134-1-git-send-email-changbin.du@intel.com> <20170601102139.GA13811@krava> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <20170601102139.GA13811@krava> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 01, 2017 at 12:21:39PM +0200, Jiri Olsa wrote: > On Thu, Jun 01, 2017 at 05:03:21PM +0800, changbin.du@intel.com wrote: > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > > index 5762ae4..69eea3a 100644 > > --- a/tools/perf/util/sort.c > > +++ b/tools/perf/util/sort.c > > @@ -2635,6 +2635,9 @@ static char *setup_overhead(char *keys) > > if (sort__mode =3D=3D SORT_MODE__DIFF) > > return keys; > > =20 > > + if (strstr(keys, "overhead")) > > + return keys; > > + > > keys =3D prefix_if_not_in("overhead", keys); >=20 > hum, you basicaly do what's at begining of prefix_if_not_in function: >=20 > static char *prefix_if_not_in(const char *pre, char *str) > { > char *n; >=20 > if (!str || strstr(str, pre)) > return str; > ... >=20 Thanks, will change it. >=20 > could you please provide the example described in changelog? >=20 Will add example cmdline there, Thanks. > jirka --=20 Thanks, Changbin Du --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJZMNLnAAoJEAanuZwLnPNUu4QH+wdUbyLsVJ5kW2/L68XSSifK /JtXsoFFb21eI8nU8Ki+FTtYLqE1HSQ15GzU4bYWqXToJjVxANxpa/HnCnbsFIho wtflfDAOPzm9zrcG9436URUFRTKskt/BT0GMcsZEneLcLDbtvcMOMRgb0yTyw1VS MgLWbEm1KVeIxh1vCUc3CMmebAA9mvU+CRkY1mAaKAaDt9ClE9wo6DG+gbwCC2Bf PtFLM2p5WfUAnMCKb7xHSa0BriuJCilx1mnbEgzAf0Lref8RK1OvbNHH6Ivcx9Mv AL8ZtUJwespAZID6xyLyxXXepZ37uRTD+vdzHwXLiO3/A/WLAxnKYl+tFQl7tx0= =gE6D -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--