From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751147AbdFBITC (ORCPT ); Fri, 2 Jun 2017 04:19:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:46755 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750747AbdFBITA (ORCPT ); Fri, 2 Jun 2017 04:19:00 -0400 Date: Fri, 2 Jun 2017 10:18:57 +0200 From: Michal Hocko To: Yu Zhao Cc: Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] swap: cond_resched in swap_cgroup_prepare() Message-ID: <20170602081855.GE29840@dhcp22.suse.cz> References: <20170601195635.20744-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170601195635.20744-1-yuzhao@google.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 01-06-17 12:56:35, Yu Zhao wrote: > Saw need_resched() warnings when swapping on large swapfile (TBs) > because page allocation in swap_cgroup_prepare() took too long. Hmm, but the page allocator makes sure to cond_resched for sleeping allocations. I guess what you mean is something different. It is not the allocation which took too look but there are too many of them and none of them sleeps because there is enough memory and the allocator doesn't sleep in that case. Right? > We already cond_resched when freeing page in swap_cgroup_swapoff(). > Do the same for the page allocation. > > Signed-off-by: Yu Zhao The patch itself makes sense to me, the changelog could see some clarification but other than that Acked-by: Michal Hocko > --- > mm/swap_cgroup.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/swap_cgroup.c b/mm/swap_cgroup.c > index ac6318a064d3..3405b4ee1757 100644 > --- a/mm/swap_cgroup.c > +++ b/mm/swap_cgroup.c > @@ -48,6 +48,9 @@ static int swap_cgroup_prepare(int type) > if (!page) > goto not_enough_page; > ctrl->map[idx] = page; > + > + if (!(idx % SWAP_CLUSTER_MAX)) > + cond_resched(); > } > return 0; > not_enough_page: > -- > 2.13.0.219.gdb65acc882-goog -- Michal Hocko SUSE Labs