From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751212AbdFBOEj (ORCPT ); Fri, 2 Jun 2017 10:04:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:54018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdFBOEh (ORCPT ); Fri, 2 Jun 2017 10:04:37 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DDE923A00 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 2 Jun 2017 11:04:33 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Jiri Olsa , lkml , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern Subject: Re: [PATCHv2] perf test: Disable breakpoint signal tests for powerpc Message-ID: <20170602140433.GM2899@kernel.org> References: <20170516174942.13650-1-jolsa@kernel.org> <20170601130458.GB2899@kernel.org> <20170601131007.GA27070@krava> <20170601205450.GA398@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170601205450.GA398@krava> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Jun 01, 2017 at 10:54:50PM +0200, Jiri Olsa escreveu: > > + if (t->is_supported && !t->is_supported()) { > + pr_debug("%2d: %-*s: Disabled\n", i, width, t->desc); This isn't clear, I'll change this to leave the pr_debug up to the ->is_supported() code (that will receive the struct test pointer too), that can then say something more clear like what you put in that comment. This way, ppc hackers running 'perf test' will see that longstanding TODO entry ;-) - Arnaldo > + continue; > + } > + > pr_info("%2d: %-*s:", i, width, t->desc); > > if (intlist__find(skiplist, i)) { > diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h > index 631859629403..577363809c9b 100644 > --- a/tools/perf/tests/tests.h > +++ b/tools/perf/tests/tests.h > @@ -34,6 +34,7 @@ struct test { > int (*get_nr)(void); > const char *(*get_desc)(int subtest); > } subtest; > + bool (*is_supported)(void); > }; > > /* Tests */ > @@ -99,6 +100,8 @@ const char *test__clang_subtest_get_desc(int subtest); > int test__clang_subtest_get_nr(void); > int test__unit_number__scnprint(int subtest); > > +bool test__bp_signal_is_supported(void); > + > #if defined(__arm__) || defined(__aarch64__) > #ifdef HAVE_DWARF_UNWIND_SUPPORT > struct thread; > -- > 2.9.4