From: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee,
Chun-Yi" <jlee@suse.com>, Len Brown <lenb@kernel.org>
Subject: [PATCH] acpi: handle the acpi hotplug schedule error
Date: Sat, 3 Jun 2017 15:38:58 +0800 [thread overview]
Message-ID: <20170603073858.2332-1-jlee@suse.com> (raw)
Kernel should the decrement reference count of acpi device when
acpi hotplug work scheduling is failed. And, kernel should evaluates
_OST to notify BIOS the failure.
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
---
drivers/acpi/bus.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 34fbe02..2f2cec9 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -427,8 +427,14 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
(driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS))
driver->ops.notify(adev, type);
- if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
- return;
+ if (hotplug_event) {
+ if (ACPI_FAILURE(acpi_hotplug_schedule(adev, type))) {
+ acpi_bus_put_acpi_device(adev);
+ goto err;
+ } else {
+ return;
+ }
+ }
acpi_bus_put_acpi_device(adev);
return;
--
2.10.2
next reply other threads:[~2017-06-03 7:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 7:38 Lee, Chun-Yi [this message]
2017-06-07 6:05 [PATCH] acpi: handle the acpi hotplug schedule error Lee, Chun-Yi
2017-06-07 8:36 ` Andy Shevchenko
2017-06-07 10:18 ` joeyli
2017-06-07 10:46 ` Andy Shevchenko
2017-06-07 15:39 ` joeyli
2017-06-07 16:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170603073858.2332-1-jlee@suse.com \
--to=joeyli.kernel@gmail.com \
--cc=jlee@suse.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).