linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joel Fernandes <joelaf@google.com>
To: linux-kernel@vger.kernel.org
Cc: Joel Fernandes <joelaf@google.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	kernel-team@android.com
Subject: [RFC v2 0/4] tracing: Add support to record and display tgid of tasks
Date: Sat,  3 Jun 2017 21:03:46 -0700	[thread overview]
Message-ID: <20170604040350.12641-1-joelaf@google.com> (raw)

Hi Steven, Ingo,

Here is a rework of the last RFC [1] I posted. Its a a complete rewrite from
scratch to be more upstream friendly.

Android systrace viewer heavily depends on the tgid to group tasks. tgid is
also useful for analyzing traces and generating stats for groups of tasks.

Basically in this approach I try to make sure there is no overhead in terms of
runtime or space usage for existing users who don't need tgid. Only if the
trace option is enabled will the tgid table which does the mapping be allocated
and used.

I tested these and they are showing good results so far, looking forward to
getting your feedback and thoughts on them. Thank you.

[1] https://patchwork.kernel.org/patch/9728283/

Joel Fernandes (4):
  tracing: Remove unused declaration of trace_stop_cmdline_recording
  tracing: Add support for recording tgid of tasks
  tracing: Add support for display of tgid in trace output
  tracing/ftrace: Add support to record and display tgid

 include/linux/trace_events.h         |  10 ++-
 kernel/trace/blktrace.c              |   2 +-
 kernel/trace/trace.c                 | 141 +++++++++++++++++++++++++++--------
 kernel/trace/trace.h                 |   9 ++-
 kernel/trace/trace_events.c          |  84 ++++++++++++++++++---
 kernel/trace/trace_functions.c       |  24 +++++-
 kernel/trace/trace_functions_graph.c |   4 +-
 kernel/trace/trace_output.c          |   9 +++
 kernel/trace/trace_sched_switch.c    |  67 ++++++++++++-----
 kernel/trace/trace_selftest.c        |   2 +-
 10 files changed, 283 insertions(+), 69 deletions(-)

Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: kernel-team@android.com
Signed-off-by: Joel Fernandes <joelaf@google.com>
-- 
2.13.0.506.g27d5fe0cd-goog

             reply	other threads:[~2017-06-04  4:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-04  4:03 Joel Fernandes [this message]
2017-06-04  4:03 ` [RFC v2 1/4] tracing: Remove unused declaration of trace_stop_cmdline_recording Joel Fernandes
2017-06-04  4:03 ` [RFC v2 2/4] tracing: Add support for recording tgid of tasks Joel Fernandes
2017-06-04  5:44   ` Joel Fernandes
2017-06-04  4:03 ` [RFC v2 3/4] tracing: Add support for display of tgid in trace output Joel Fernandes
2017-06-04  4:03 ` [RFC v2 4/4] tracing/ftrace: Add support to record and display tgid Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170604040350.12641-1-joelaf@google.com \
    --to=joelaf@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).