From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Lukas Wunner <lukas@wunner.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <yehezkel.bernat@intel.com>,
Amir Levy <amir.jer.levy@intel.com>,
Andy Lutomirski <luto@kernel.org>,
Mario Limonciello <Mario.Limonciello@dell.com>,
Jared.Dominguez@dell.com,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 06/27] thunderbolt: Rework capability handling
Date: Mon, 5 Jun 2017 09:42:30 +0300 [thread overview]
Message-ID: <20170605064230.GI3454@lahna.fi.intel.com> (raw)
In-Reply-To: <CAHp75Vd01jgVX2rhi_BzMbY0c5OaJAL9LGFhX--TPjMgBg193w@mail.gmail.com>
On Sun, Jun 04, 2017 at 09:15:03PM +0300, Andy Shevchenko wrote:
> On Sun, Jun 4, 2017 at 6:06 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Sun, Jun 04, 2017 at 06:00:02PM +0300, Mika Westerberg wrote:
> >> On Sun, Jun 04, 2017 at 03:52:29PM +0200, Lukas Wunner wrote:
> >> > On Fri, Jun 02, 2017 at 05:05:03PM +0300, Mika Westerberg wrote:
> >> > > Organization of the capabilities in switches and ports is not so random
> >> > > after all. Rework the capability handling functionality so that it
> >> > > follows how capabilities are organized and provide two new functions
> >> > > (tb_switch_find_vsec_cap() and tb_port_find_cap()) which can be used to
> >> > ^^^^^^^^
> >> >
> >> > I assume VSEC is the same acronym as in the PCIe spec, so this naming
> >> > scheme results in "vendor specific extended capability capability",
> >> > which is maybe a bit odd.
> >>
> >> AFAIK it comes from Vendor SpEcifiC but I'm not 100% sure ;-) The Alpine
> >> Ridge datasheet calls it also VSEC capability which is why we chose the
> >> naming accordingly.
> >
> > That said, it could also come from Vendor SpEcific Capability. I can
> > change it to tb_switch_find_vsec() if that works better.
>
> I would folllow PCI existing namings, i.e.
> _vse_cap()
Indeed this sounds better.
I looked at the TBT specs again and they just use VSEC but do not open
the acronym any further. I guess the "Vendor Specific Extended
Capability" as Lukas pointed out is the correct one.
I'll change the patch to use tb_switch_find_vse_cap() and rename
TB_VSEC_CAP_* to TB_VSE_CAP_* if there are no objections.
next prev parent reply other threads:[~2017-06-05 6:42 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 14:04 [PATCH v3 00/27] Thunderbolt security levels and NVM firmware upgrade Mika Westerberg
2017-06-02 14:04 ` [PATCH v3 01/27] thunderbolt: Use const buffer pointer in write operations Mika Westerberg
2017-06-02 14:04 ` [PATCH v3 02/27] thunderbolt: No need to read UID of the root switch on resume Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 03/27] thunderbolt: Do not try to read UID if DROM offset is read as 0 Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 04/27] thunderbolt: Do not warn about newer DROM versions Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 05/27] thunderbolt: Add MSI-X support Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 06/27] thunderbolt: Rework capability handling Mika Westerberg
2017-06-04 13:52 ` Lukas Wunner
2017-06-04 15:00 ` Mika Westerberg
2017-06-04 15:06 ` Mika Westerberg
2017-06-04 18:15 ` Andy Shevchenko
2017-06-05 6:42 ` Mika Westerberg [this message]
2017-06-02 14:05 ` [PATCH v3 07/27] thunderbolt: Allow passing NULL to tb_ctl_free() Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 08/27] thunderbolt: Introduce thunderbolt bus and connection manager Mika Westerberg
2017-06-05 15:10 ` Andreas Noever
2017-06-02 14:05 ` [PATCH v3 09/27] thunderbolt: Convert switch to a device Mika Westerberg
2017-06-03 9:11 ` Greg Kroah-Hartman
2017-06-02 14:05 ` [PATCH v3 10/27] thunderbolt: Fail switch adding operation if reading DROM fails Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 11/27] thunderbolt: Do not fail if DROM data CRC32 is invalid Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 12/27] thunderbolt: Refactor and fix parsing of port drom entries Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 13/27] thunderbolt: Read vendor and device name from DROM Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 14/27] thunderbolt: Move control channel messages to tb_msgs.h Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 15/27] thunderbolt: Expose get_route() to other files Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 16/27] thunderbolt: Expose make_header() " Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 17/27] thunderbolt: Let the connection manager handle all notifications Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 18/27] thunderbolt: Rework control channel to be more reliable Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs Mika Westerberg
2017-06-05 8:14 ` Lukas Wunner
2017-06-05 9:32 ` Mika Westerberg
2017-06-05 12:07 ` Lukas Wunner
2017-06-05 12:55 ` Mika Westerberg
2017-06-05 13:33 ` Mika Westerberg
2017-06-05 13:46 ` Lukas Wunner
2017-06-05 13:52 ` Mika Westerberg
2017-06-05 14:21 ` Andy Shevchenko
2017-06-05 14:44 ` Mika Westerberg
2017-06-05 15:20 ` Greg Kroah-Hartman
2017-06-05 15:40 ` Mika Westerberg
2017-06-05 15:50 ` Mario.Limonciello
2017-06-05 16:49 ` Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 20/27] thunderbolt: Add support for NHI mailbox Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 21/27] thunderbolt: Store Thunderbolt generation in the switch structure Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 22/27] thunderbolt: Add support for DMA configuration based mailbox Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 23/27] thunderbolt: Do not touch the hardware if the NHI is gone on resume Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 24/27] thunderbolt: Add support for Internal Connection Manager (ICM) Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 25/27] thunderbolt: Add support for host and device NVM firmware upgrade Mika Westerberg
2017-06-02 14:05 ` [PATCH v3 26/27] thunderbolt: Add documentation how Thunderbolt bus can be used Mika Westerberg
2017-06-03 9:14 ` Greg Kroah-Hartman
2017-06-02 14:05 ` [PATCH v3 27/27] MAINTAINERS: Add maintainers for Thunderbolt driver Mika Westerberg
2017-06-02 17:58 ` [PATCH v3 00/27] Thunderbolt security levels and NVM firmware upgrade Andy Shevchenko
2017-06-03 9:17 ` Greg Kroah-Hartman
2017-06-05 7:18 ` Mika Westerberg
2017-06-05 17:01 ` Andreas Noever
2017-06-05 19:43 ` Mika Westerberg
2017-06-06 6:03 ` Greg Kroah-Hartman
2017-06-06 6:41 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170605064230.GI3454@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Jared.Dominguez@dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=amir.jer.levy@intel.com \
--cc=andreas.noever@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=luto@kernel.org \
--cc=michael.jamet@intel.com \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).