From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751437AbdFENAo (ORCPT ); Mon, 5 Jun 2017 09:00:44 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:35854 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357AbdFENAZ (ORCPT ); Mon, 5 Jun 2017 09:00:25 -0400 Date: Mon, 5 Jun 2017 14:00:21 +0100 From: Matt Fleming To: Peter Zijlstra Cc: mingo@kernel.org, tglx@linutronix.de, riel@redhat.com, hpa@zytor.com, efault@gmx.de, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, lvenanci@redhat.com, xiaolong.ye@intel.com, kitsunyan@inbox.ru, clm@fb.com Subject: Re: hackbench vs select_idle_sibling; was: [tip:sched/core] sched/fair, cpumask: Export for_each_cpu_wrap() Message-ID: <20170605130021.GA3339@codeblueprint.co.uk> References: <20170414122005.o35me2h5nowqkxbv@hirez.programming.kicks-ass.net> <20170517105350.hk5m4h4jb6dfr65a@hirez.programming.kicks-ass.net> <20170519150035.GA2879@codeblueprint.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170519150035.GA2879@codeblueprint.co.uk> User-Agent: Mutt/1.5.24+42 (6e565710a064) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 May, at 04:00:35PM, Matt Fleming wrote: > On Wed, 17 May, at 12:53:50PM, Peter Zijlstra wrote: > > > > Please test.. > > Results are still coming in but things do look better with your patch > applied. > > It does look like there's a regression when running hackbench in > process mode and when the CPUs are not fully utilised, e.g. check this > out: This turned out to be a false positive; your patch improves things as far as I can see.