From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753681AbdFEQty (ORCPT ); Mon, 5 Jun 2017 12:49:54 -0400 Received: from mga04.intel.com ([192.55.52.120]:34837 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752127AbdFEQtw (ORCPT ); Mon, 5 Jun 2017 12:49:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,302,1493708400"; d="scan'208";a="95784556" Date: Mon, 5 Jun 2017 19:49:35 +0300 From: Mika Westerberg To: Mario.Limonciello@dell.com Cc: gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, lukas@wunner.de, andreas.noever@gmail.com, michael.jamet@intel.com, yehezkel.bernat@intel.com, amir.jer.levy@intel.com, luto@kernel.org, Jared.Dominguez@dell.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs Message-ID: <20170605164935.GS3454@lahna.fi.intel.com> References: <20170602140524.23367-20-mika.westerberg@linux.intel.com> <20170605081437.GA7519@wunner.de> <20170605093249.GK3454@lahna.fi.intel.com> <20170605120756.GA7793@wunner.de> <20170605125507.GL3454@lahna.fi.intel.com> <20170605133334.GM3454@lahna.fi.intel.com> <1496672494.22624.4.camel@linux.intel.com> <20170605152036.GA19810@kroah.com> <20170605154057.GQ3454@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 05, 2017 at 03:50:24PM +0000, Mario.Limonciello@dell.com wrote: > And presumably that's mostly for debugging purposes and will lead > to additional quirks to get "automatic" to do the right thing on those > machines that's it's found to be needed or more beneficial. I would say that this is only for kernel hackers, like Lukas, who know what they are doing. But then again people needing that could just comment out one line in nhi.c to pick the implementation they want without any module parameter ;-) I think I'm not going to add that patch to this series after all - we can always do it later if really really needed.