From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416AbdFFJQG (ORCPT ); Tue, 6 Jun 2017 05:16:06 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35930 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbdFFJQF (ORCPT ); Tue, 6 Jun 2017 05:16:05 -0400 Date: Tue, 6 Jun 2017 10:16:01 +0100 From: Lee Jones To: Charles Keepax Cc: a.hajda@samsung.com, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] mfd: arizona: Fix typo using hard-coded register Message-ID: <20170606091601.axffjmgzewciiuqq@dell> References: <1496738793-12975-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1496738793-12975-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Jun 2017, Charles Keepax wrote: > A hardcoded register is accidentally used instead of the register > address passed into the function. Correct this and use the appropriate > variable. This would cause minor issues on wm5102, but all other > devices using this driver would have been unaffected. > > Fixes: commit ef84f885e037 ("mfd: arizona: Refactor arizona_poll_reg") > Reported-by: Andrzej Hajda > Signed-off-by: Charles Keepax > --- > drivers/mfd/arizona-core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 75488e6..8d46e3a 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -245,8 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona, > int ret; > > ret = regmap_read_poll_timeout(arizona->regmap, > - ARIZONA_INTERRUPT_RAW_STATUS_5, val, > - ((val & mask) == target), > + reg, val, ((val & mask) == target), > ARIZONA_REG_POLL_DELAY_US, > timeout_ms * 1000); > if (ret) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog