From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751764AbdFGJPl (ORCPT ); Wed, 7 Jun 2017 05:15:41 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35350 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbdFGJPj (ORCPT ); Wed, 7 Jun 2017 05:15:39 -0400 From: "Guillermo O. Freschi" To: Oleg Drokin , lustre-devel@lists.lustre.org, linux-kernel@vger.kernel.org Cc: "Guillermo O. Freschi" Subject: [PATCH 2/2] drivers: staging/lustre: conrpc.c - fix sparse warning: warning: incorrect type in argument * (different address spaces) Date: Wed, 7 Jun 2017 06:15:19 -0300 Message-Id: <20170607091519.5248-2-kedrot@gmail.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170607091519.5248-1-kedrot@gmail.com> References: <8FAAC9A9-A33E-40FA-B073-C4E0EAA7725A@intel.com> <20170607091519.5248-1-kedrot@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The calls to `copy_to_user` suggest that `ent` is pointing to userspace memory, but `ent` is missing the `__user` qualifier. Signed-off-by: Guillermo O. Freschi --- drivers/staging/lustre/lnet/selftest/conrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/selftest/conrpc.c b/drivers/staging/lustre/lnet/selftest/conrpc.c index f4578200994f..04a5d7e80151 100644 --- a/drivers/staging/lustre/lnet/selftest/conrpc.c +++ b/drivers/staging/lustre/lnet/selftest/conrpc.c @@ -469,7 +469,7 @@ lstcon_rpc_trans_interpreter(struct lstcon_rpc_trans *trans, { struct list_head tmp; struct list_head __user *next; - struct lstcon_rpc_ent *ent; + struct lstcon_rpc_ent __user *ent; struct srpc_generic_reply *rep; struct lstcon_rpc *crpc; struct srpc_msg *msg; -- 2.11.0