From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751532AbdFGNnf (ORCPT ); Wed, 7 Jun 2017 09:43:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44644 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbdFGNnd (ORCPT ); Wed, 7 Jun 2017 09:43:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 313A880E7A Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=benjamin.tissoires@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 313A880E7A Date: Wed, 7 Jun 2017 15:43:27 +0200 From: Benjamin Tissoires To: Dmitry Torokhov Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH v2 0/8] HID: Consolidate serializing ope/close in transport drivers Message-ID: <20170607134327.GE16591@mail.corp.redhat.com> References: <20170607065938.33332-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170607065938.33332-1-dmitry.torokhov@gmail.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 07 Jun 2017 13:43:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 06 2017 or thereabouts, Dmitry Torokhov wrote: > This originally came about as report of uhid sending duplicate open and > premature close when hidraw was used alongside of input. After looking at > the drivers I think we should consolidate user tracking inside of the HID > core. While implementing this, there were a few cleanups as well. > > V2: > > - added greybus hid changes > - added error handling in hiddev around hid_hw_open which is __much_check > Looks good to me: Reviewed-by: Benjamin Tissoires > Dmitry Torokhov (8): > HID: hiddev: use hid_hw_open/close instead of usbhid_open/close > HID: hiddev: use hid_hw_power instead of usbhid_get/put_power > HID: usbhid: do not rely on hid->open when deciding to do IO > HID: serialize hid_hw_open and hid_hw_close > HID: i2c-hid: remove custom locking from i2c_hid_open/close > HID: usbhid: remove custom locking from usbhid_open/close > greybus: hid: remove custom locking from gb_hid_open/close > HID: remove no longer used hid->open field > > drivers/hid/hid-core.c | 89 +++++++++++++++++++++++++ > drivers/hid/i2c-hid/i2c-hid.c | 32 +++------ > drivers/hid/usbhid/hid-core.c | 150 ++++++++++++++++++++---------------------- > drivers/hid/usbhid/hiddev.c | 24 +++---- > drivers/hid/usbhid/usbhid.h | 15 +++-- > drivers/staging/greybus/hid.c | 43 ++++-------- > include/linux/hid.h | 73 +++----------------- > 7 files changed, 214 insertions(+), 212 deletions(-) > > Thanks. > > -- > Dmitry >