Re: [PATCH 15/16] platform/x86: wmi-mof: New driver to expose embedded WMI MOF metadata

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 2394 bytes --]

On Wednesday 07 June 2017 22:23:08 Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Pali Rohár [mailto:pali.rohar@gmail.com]
> > Sent: Wednesday, June 7, 2017 12:39 PM
> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > Cc: luto@amacapital.net; dvhart@infradead.org; platform-driver-
> > x86@vger.kernel.org; andriy.shevchenko@linux.intel.com;
> > luto@kernel.org; rjw@rjwysocki.net; linux-kernel@vger.kernel.org;
> > linux-acpi@vger.kernel.org Subject: Re: [PATCH 15/16]
> > platform/x86: wmi-mof: New driver to expose embedded WMI MOF
> > metadata
> > 
> > On Tuesday 06 June 2017 15:56:21 Pali Rohár wrote:
> > > On Tuesday 06 June 2017 13:46:16 Mario.Limonciello@dell.com wrote:
> > > > 2) On my system when you expand the arguments for "void DoBFn"
> > > > the source doesn't describe individual arguments like you do.
> > > > Again this might not matter to MOF parsing tools but wanted to
> > > > let you know in case it does.
> > > 
> > > I know, this part is missing. Order of arguments are only in ID
> > > qualifier and not sorted + in/out de-duplicated.
> > 
> > Implemented! Now arguments are correctly placed based on ID
> > qualifier.
> 
> I think it's still off a little though.
> 
> What I'm getting back now from bmf2mof is:
> 	void DoBFn([in, Description("Fn buf"), out] BDat Data);
> 
> Whereas source puts Description as the last argument:
> 	void DoBFn([in, out, Description("Fn buf")] BDat Data);

In BMOF from my Latitude E6440 there are specified two parameters with 
index 0. One with qualifiers ("in", Description("Fn buf")) and one with 
("out", Description("Fn buf")). I think you have similar/same data in 
BMOF.

In my bmf2mof I just combined those two parameters into one (when name, 
type and index matches) and concatenate also qualifiers with removing 
duplicates.

Do not know what is correct way, but I think qualifiers are just 
unordered set. MS decompiler probably put "in" and "out" qualifiers 
before any other for better readability.

> > > > source:
> > > > 	void DoBFn([in, out, Description("Fn buf")] BDat Data);
> > > > 
> > > > bmf2mof:
> > > > 	void doBFn([in, Description("Fn buf"), ID(0)] BDat Data, [out,
> > > > 	Description("Fn buf"), ID(0)] BDat Data);
> > 
> > --
> > Pali Rohár
> > pali.rohar@gmail.com

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]