From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbdFHHc7 (ORCPT ); Thu, 8 Jun 2017 03:32:59 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:43979 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbdFHHbu (ORCPT ); Thu, 8 Jun 2017 03:31:50 -0400 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , kernel-team@lge.com, David Ahern , Adrian Hunter , Wang Nan Subject: [PATCH v4 2/9] perf tools: Fix a memory leak in __open_dso() Date: Thu, 8 Jun 2017 16:31:02 +0900 Message-Id: <20170608073109.30699-3-namhyung@kernel.org> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170608073109.30699-1-namhyung@kernel.org> References: <20170608073109.30699-1-namhyung@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The name should be freed on error path. Signed-off-by: Namhyung Kim --- tools/perf/util/dso.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index b27d127cdf68..1f29e4fe7af0 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c @@ -412,8 +412,10 @@ static int __open_dso(struct dso *dso, struct machine *machine) return -EINVAL; } - if (!is_regular_file(name)) + if (!is_regular_file(name)) { + free(name); return -EINVAL; + } fd = do_open(name); free(name); -- 2.13.1