linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	linux-rtc@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 16/25] rtc: rk808: Switch to use %pt
Date: Thu,  8 Jun 2017 16:48:02 +0300	[thread overview]
Message-ID: <20170608134811.60786-17-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170608134811.60786-1-andriy.shevchenko@linux.intel.com>

Use %pt instead of open coded variant to print content of
struct rtc_time in human readable format.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/rtc/rtc-rk808.c | 20 ++++++--------------
 1 file changed, 6 insertions(+), 14 deletions(-)

diff --git a/drivers/rtc/rtc-rk808.c b/drivers/rtc/rtc-rk808.c
index 35c9aada07c8..711dca5707cd 100644
--- a/drivers/rtc/rtc-rk808.c
+++ b/drivers/rtc/rtc-rk808.c
@@ -138,9 +138,7 @@ static int rk808_rtc_readtime(struct device *dev, struct rtc_time *tm)
 	tm->tm_year = (bcd2bin(rtc_data[5] & YEARS_REG_MSK)) + 100;
 	tm->tm_wday = bcd2bin(rtc_data[6] & WEEKS_REG_MSK);
 	rockchip_to_gregorian(tm);
-	dev_dbg(dev, "RTC date/time %4d-%02d-%02d(%d) %02d:%02d:%02d\n",
-		1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday,
-		tm->tm_wday, tm->tm_hour, tm->tm_min, tm->tm_sec);
+	dev_dbg(dev, "RTC date/time %ptd(%d) %ptt\n", tm, tm->tm_wday, tm);
 
 	return ret;
 }
@@ -153,9 +151,7 @@ static int rk808_rtc_set_time(struct device *dev, struct rtc_time *tm)
 	u8 rtc_data[NUM_TIME_REGS];
 	int ret;
 
-	dev_dbg(dev, "set RTC date/time %4d-%02d-%02d(%d) %02d:%02d:%02d\n",
-		1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday,
-		tm->tm_wday, tm->tm_hour, tm->tm_min, tm->tm_sec);
+	dev_dbg(dev, "set RTC date/time %ptd(%d) %ptt\n", tm, tm->tm_wday, tm);
 	gregorian_to_rockchip(tm);
 	rtc_data[0] = bin2bcd(tm->tm_sec);
 	rtc_data[1] = bin2bcd(tm->tm_min);
@@ -216,10 +212,8 @@ static int rk808_rtc_readalarm(struct device *dev, struct rtc_wkalrm *alrm)
 		return ret;
 	}
 
-	dev_dbg(dev, "alrm read RTC date/time %4d-%02d-%02d(%d) %02d:%02d:%02d\n",
-		1900 + alrm->time.tm_year, alrm->time.tm_mon + 1,
-		alrm->time.tm_mday, alrm->time.tm_wday, alrm->time.tm_hour,
-		alrm->time.tm_min, alrm->time.tm_sec);
+	dev_dbg(dev, "alrm read RTC date/time %ptd(%d) %ptt\n",
+		&alrm->time, alrm->time.tm_wday, &alrm->time);
 
 	alrm->enabled = (int_reg & BIT_RTC_INTERRUPTS_REG_IT_ALARM_M) ? 1 : 0;
 
@@ -261,10 +255,8 @@ static int rk808_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
 		dev_err(dev, "Failed to stop alarm: %d\n", ret);
 		return ret;
 	}
-	dev_dbg(dev, "alrm set RTC date/time %4d-%02d-%02d(%d) %02d:%02d:%02d\n",
-		1900 + alrm->time.tm_year, alrm->time.tm_mon + 1,
-		alrm->time.tm_mday, alrm->time.tm_wday, alrm->time.tm_hour,
-		alrm->time.tm_min, alrm->time.tm_sec);
+	dev_dbg(dev, "alrm set RTC date/time %ptd(%d) %ptt\n",
+		&alrm->time, alrm->time.tm_wday, &alrm->time);
 
 	gregorian_to_rockchip(&alrm->time);
 	alrm_data[0] = bin2bcd(alrm->time.tm_sec);
-- 
2.11.0

  parent reply	other threads:[~2017-06-08 13:49 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 13:47 [PATCH v1 00/25] lib, rtc: Print rtc_time via %pt[dt][rv] Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 01/25] lib/vsprintf: Remove useless NULL checks Andy Shevchenko
2017-06-08 20:59   ` Rasmus Villemoes
2017-07-20 10:22     ` Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 02/25] lib/vsprintf: Make decspec global Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 03/25] lib/vsprintf: Make strspec global Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 04/25] lib/vsprintf: Print time and date in human readable format via %pt Andy Shevchenko
2017-06-08 14:49   ` Arnd Bergmann
2017-06-08 14:55     ` Andy Shevchenko
2017-06-08 15:05       ` Alexandre Belloni
2017-06-08 17:57         ` Andy Shevchenko
2017-06-08 18:41           ` Alexandre Belloni
2017-06-08 18:49             ` Andy Shevchenko
2017-06-08 20:42               ` Rasmus Villemoes
2017-06-08 21:25                 ` Andy Shevchenko
2017-06-08 21:45                   ` Arnd Bergmann
2017-07-20 10:30                     ` Andy Shevchenko
2017-06-08 15:33       ` Arnd Bergmann
2017-06-08 15:48         ` Joe Perches
2017-06-08 18:02         ` Andy Shevchenko
2017-06-08 23:09           ` Joe Perches
2017-06-08 13:47 ` [PATCH v1 05/25] ds1302: Switch to use %pt Andy Shevchenko
2017-06-08 14:00   ` Greg Kroah-Hartman
2017-06-08 13:47 ` [PATCH v1 06/25] rtc: " Andy Shevchenko
2017-06-08 14:00   ` Greg Kroah-Hartman
2017-06-08 18:38     ` Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 07/25] rtc: at91rm9200: " Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 08/25] rtc: at91sam9: " Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 09/25] rtc: m41t80: " Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 10/25] rtc: m48t59: " Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 11/25] rtc: mcp795: " Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 12/25] rtc: pcf50633: " Andy Shevchenko
2017-06-08 13:47 ` [PATCH v1 13/25] rtc: pic32: " Andy Shevchenko
2017-06-08 13:48 ` [PATCH v1 14/25] rtc: pm8xxx: " Andy Shevchenko
2017-06-08 13:48 ` [PATCH v1 15/25] rtc: puv3: " Andy Shevchenko
2017-06-08 13:48 ` Andy Shevchenko [this message]
2017-06-08 13:48 ` [PATCH v1 17/25] rtc: rx6110: " Andy Shevchenko
2017-06-08 13:48 ` [PATCH v1 18/25] rtc: rx8025: " Andy Shevchenko
2017-06-08 13:48 ` [PATCH v1 19/25] rtc: s3c: " Andy Shevchenko
2017-06-08 13:48 ` [PATCH v1 20/25] rtc: s5m: " Andy Shevchenko
2017-06-08 16:46   ` Krzysztof Kozlowski
2017-06-08 13:48 ` [PATCH v1 21/25] rtc: tegra: " Andy Shevchenko
2017-06-08 13:48 ` [PATCH v1 22/25] mk68/mac: " Andy Shevchenko
2017-06-08 13:48 ` [PATCH v1 23/25] Input: hp_sdc_rtc - " Andy Shevchenko
2017-06-08 13:48 ` [PATCH v1 24/25] kdb: " Andy Shevchenko
2017-06-09 13:42   ` Daniel Thompson
2017-10-12 13:31   ` Arnd Bergmann
2017-10-12 17:05     ` Andy Shevchenko
2017-10-13  7:42       ` Arnd Bergmann
2017-06-08 13:48 ` [PATCH v1 25/25] PM: " Andy Shevchenko
2017-06-08 17:16   ` Rafael J. Wysocki
2017-06-08 14:52 ` [PATCH v1 00/25] lib, rtc: Print rtc_time via %pt[dt][rv] Joe Perches
2017-06-08 15:02   ` Andy Shevchenko
2017-06-09  5:08     ` Joe Perches
2017-07-18 17:50 ` Joe Perches
2017-07-18 17:55   ` Andy Shevchenko
2017-07-18 18:32     ` Joe Perches
2017-07-18 19:57   ` Mark Salyzyn
2017-07-20 10:33     ` Andy Shevchenko
2017-07-20 17:57       ` Mark Salyzyn
2017-07-21  4:07         ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170608134811.60786-17-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=rasmus.villemoes@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).