From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751878AbdFHTm1 (ORCPT ); Thu, 8 Jun 2017 15:42:27 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:42057 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851AbdFHTmZ (ORCPT ); Thu, 8 Jun 2017 15:42:25 -0400 Date: Thu, 8 Jun 2017 21:42:22 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 6/7] net: dsa: mv88e6xxx: rework jumbo size operation Message-ID: <20170608194222.GJ20216@lunn.ch> References: <20170608190445.24443-1-vivien.didelot@savoirfairelinux.com> <20170608190445.24443-7-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170608190445.24443-7-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 08, 2017 at 03:04:44PM -0400, Vivien Didelot wrote: > Marvell chips have a Jumbo Mode to set the maximum frame size (MTU). > > The mv88e6xxx_ops structure is meant to contain generic functionalities, > no driver logic. Change port_jumbo_config to port_set_jumbo_size setting > the mode from a given maximum size value. > > There is no functional changes since we still use 10240 bytes. > > At the same time, correctly clear all Jumbo Mode bits before writing. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew