From: Peter Zijlstra <peterz@infradead.org>
To: "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>,
James Hartsock <hartsjc@redhat.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Tim Wright <tim@binbash.co.uk>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] nohz: Fix spurious warning when hrtimer and clockevent get out of sync
Date: Fri, 9 Jun 2017 14:26:21 +0200 [thread overview]
Message-ID: <20170609122621.hptdcosdf6ptohta@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170609121346.km66edd6v2sjinhc@sasha-lappy>
On Fri, Jun 09, 2017 at 12:13:49PM +0000, Levin, Alexander (Sasha Levin) wrote:
> On Fri, Jun 09, 2017 at 02:48:57AM +0200, Frederic Weisbecker wrote:
> > On Thu, Jun 08, 2017 at 10:13:38PM +0000, Levin, Alexander (Sasha Levin) wrote:
> > > On Thu, Jun 08, 2017 at 09:07:05PM +0200, Frederic Weisbecker wrote:
> > > > Awesome, these traces have been very helpful! So now I think I get what's going on.
> > > > Can you please test the following fix?
> > >
> > > With the patch, I hit the warning early on boot:
> > >
> > > [ 1.423727] clocksource: Switched to clocksource kvm-clock
> > > [ 1.429326] ------------[ cut here ]------------
> > > [ 1.430234] WARNING: CPU: 1 PID: 0 at kernel/time/tick-sched.c:792 __tick_nohz_idle_enter+0xe1c/0x15c0
> >
> > Oh sorry, I inverted some conditional. It warns as soon as the tick is completely stopped
> > and not just deferred, which seldom happen on my testbox.
> >
> > I need to learn programming again.
> >
> > Here is the fixed version:
>
> These warnings seem to have gone away, but I've started seeing a new one:
>
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 12525 at kernel/time/hrtimer.c:805 hrtimer_forward+0x222/0x3e0 kernel/time/hrtimer.c:805
> Kernel panic - not syncing: panic_on_warn set ...
https://lkml.kernel.org/r/20170609104457.GA39907@inn.lkp.intel.com
has a very similar splat
next prev parent reply other threads:[~2017-06-09 12:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 14:00 [PATCH 0/2] nohz: Deal with clock reprogram skipping issues v2 Frederic Weisbecker
2017-04-21 14:00 ` [PATCH 1/2] nohz: Fix again collision between tick and other hrtimers Frederic Weisbecker
2017-04-23 11:36 ` [tip:timers/urgent] " tip-bot for Frederic Weisbecker
2017-05-17 8:46 ` [tip:timers/nohz] nohz: Fix collision between tick and other hrtimers, again tip-bot for Frederic Weisbecker
2017-04-21 14:00 ` [PATCH 2/2] tick: Make sure tick timer is active when bypassing reprogramming Frederic Weisbecker
2017-04-23 11:37 ` [tip:timers/urgent] " tip-bot for Frederic Weisbecker
2017-06-03 8:06 ` [PATCH 2/2] " Levin, Alexander (Sasha Levin)
2017-06-03 12:42 ` Frederic Weisbecker
2017-06-03 13:00 ` Levin, Alexander (Sasha Levin)
2017-06-06 14:52 ` Frederic Weisbecker
2017-06-07 4:17 ` Levin, Alexander (Sasha Levin)
2017-06-07 14:14 ` Frederic Weisbecker
2017-06-07 21:36 ` Levin, Alexander (Sasha Levin)
2017-06-08 19:07 ` [PATCH] nohz: Fix spurious warning when hrtimer and clockevent get out of sync Frederic Weisbecker
2017-06-08 22:13 ` Levin, Alexander (Sasha Levin)
2017-06-09 0:48 ` Frederic Weisbecker
2017-06-09 12:13 ` Levin, Alexander (Sasha Levin)
2017-06-09 12:26 ` Peter Zijlstra [this message]
2017-06-09 13:06 ` Frederic Weisbecker
2017-04-24 8:08 ` [PATCH 0/2] nohz: Deal with clock reprogram skipping issues v2 Ingo Molnar
2017-04-24 14:04 ` Frederic Weisbecker
2017-04-24 14:45 ` Ingo Molnar
2017-04-26 14:55 ` Frederic Weisbecker
2017-04-26 18:49 ` Ingo Molnar
2017-04-26 21:07 ` Frederic Weisbecker
2017-04-24 17:01 ` [tip:timers/urgent] nohz: Print more debug info in tick_nohz_stop_sched_tick() tip-bot for Frederic Weisbecker
2017-06-13 4:04 [PATCH] nohz: Fix spurious warning when hrtimer and clockevent get out of sync Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609122621.hptdcosdf6ptohta@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alexander.levin@verizon.com \
--cc=fweisbec@gmail.com \
--cc=hartsjc@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=riel@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tim@binbash.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).