From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: "Jernej Škrabec" <jernej.skrabec@siol.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-sunxi@googlegroups.com, "Icenowy Zheng" <icenowy@aosc.xyz>
Subject: Re: [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1
Date: Fri, 9 Jun 2017 16:48:25 +0200 [thread overview]
Message-ID: <20170609144825.jdalt2xakhcenhk5@flea.home> (raw)
In-Reply-To: <4CD8A3BB-965C-4C74-884C-ACE8AAF9989B@aosc.io>
[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]
On Wed, Jun 07, 2017 at 10:21:02PM +0800, Icenowy Zheng wrote:
>
>
> 于 2017年6月7日 GMT+08:00 下午10:19:57, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
> >On Wed, Jun 07, 2017 at 05:44:56PM +0800, Icenowy Zheng wrote:
> >> 于 2017年6月7日 GMT+08:00 下午5:43:43, Maxime Ripard
> ><maxime.ripard@free-electrons.com> 写到:
> >> >On Mon, Jun 05, 2017 at 03:03:47AM +0800, Icenowy Zheng wrote:
> >> >> >You should also expand function sun4i_drv_node_is_tcon() at
> >> >sun4i_drv.c
> >> >> >with
> >> >> >new entries, but I'm not sure if this fits in this patch.
> >> >>
> >> >> Instead I think it should be renamed to something like
> >> >> "sun4i_drv_node_is_tcon_with_ch0".
> >> >
> >> >I'm not sure, or at least, it shouldn't make any difference, since
> >> >TCON without a channel 0 will not have an endpoint 0, so this will
> >be
> >> >dealt with already.
> >>
> >> But that will prevent new coders from add CH1-less TCON
> >> compatibles to this function.
> >
> >Why? We already have such TCONs (like the A33's, or V3S') in that
> >function.
>
> Sorry, CH0-less.
That's not really an issue I think, since the endpoint 0 will not be
there on those TCONs, the code will bail out.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-06-09 14:48 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 16:01 [PATCH v2 00/11] Support for H3 Composite Output support Icenowy Zheng
2017-06-04 16:01 ` [PATCH v2 01/11] dt-bindings: update the binding for Allwinner H3 TVE support Icenowy Zheng
2017-06-07 8:45 ` Maxime Ripard
2017-06-07 8:48 ` Icenowy Zheng
2017-06-09 16:49 ` Maxime Ripard
2017-06-09 16:51 ` [linux-sunxi] " Icenowy Zheng
2017-06-09 21:24 ` Jernej Škrabec
2017-06-10 15:26 ` icenowy
2017-06-13 7:41 ` Maxime Ripard
2017-06-04 16:01 ` [PATCH v2 02/11] drm: sun4i: add support for H3 mixers Icenowy Zheng
2017-06-04 16:01 ` [PATCH v2 03/11] drm: sun4i: ignore swapped mixer<->tcon connection for DE2 Icenowy Zheng
2017-06-07 9:35 ` Maxime Ripard
2017-06-07 9:44 ` Icenowy Zheng
2017-06-07 10:01 ` Icenowy Zheng
2017-06-07 14:38 ` Maxime Ripard
2017-06-07 18:15 ` Jernej Škrabec
2017-06-09 14:45 ` Maxime Ripard
2017-06-08 5:01 ` icenowy
2017-06-09 14:46 ` Maxime Ripard
2017-06-10 14:57 ` icenowy
2017-06-10 15:16 ` icenowy
2017-06-13 9:46 ` Maxime Ripard
2017-06-13 9:43 ` Maxime Ripard
2017-06-13 10:05 ` Chen-Yu Tsai
2017-06-23 7:31 ` Maxime Ripard
2017-06-04 16:01 ` [PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1 Icenowy Zheng
2017-06-04 18:46 ` Jernej Škrabec
2017-06-04 19:03 ` Icenowy Zheng
2017-06-07 9:43 ` Maxime Ripard
2017-06-07 9:44 ` Icenowy Zheng
2017-06-07 14:19 ` Maxime Ripard
2017-06-07 14:21 ` Icenowy Zheng
2017-06-09 14:48 ` Maxime Ripard [this message]
2017-06-07 10:00 ` Icenowy Zheng
2017-06-04 22:43 ` kbuild test robot
2017-06-04 16:01 ` [PATCH v2 05/11] drm: sun4i: add compatible for H3 display engine Icenowy Zheng
2017-06-04 16:01 ` [PATCH v2 06/11] drm: sun4i: add color space correction support for DE2 mixer Icenowy Zheng
2017-06-04 16:01 ` [PATCH v2 07/11] drm: sun4i: add support for the TV encoder in H3 SoC Icenowy Zheng
2017-06-07 9:38 ` Maxime Ripard
2017-06-11 6:43 ` icenowy
2017-06-13 7:44 ` Maxime Ripard
2017-06-13 9:51 ` Icenowy Zheng
2017-06-23 14:44 ` Maxime Ripard
2017-06-04 16:01 ` [PATCH v2 08/11] clk: sunxi-ng: allow CLK_DE to set CLK_PLL_DE for H3 Icenowy Zheng
2017-06-04 16:01 ` [PATCH v2 09/11] clk: sunxi-ng: export " Icenowy Zheng
2017-06-04 16:01 ` [PATCH v2 10/11] ARM: sun8i: h3: add display engine pipeline for TVE Icenowy Zheng
2017-06-07 9:42 ` Maxime Ripard
2017-06-11 6:58 ` [linux-sunxi] " icenowy
2017-06-13 8:02 ` Maxime Ripard
2017-06-04 16:01 ` [PATCH v2 11/11] [DO NOT MERGE] ARM: sun8i: h3: enable TV output on Orange Pi PC Icenowy Zheng
2017-06-07 0:26 ` [PATCH v2 00/11] Support for H3 Composite Output support icenowy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609144825.jdalt2xakhcenhk5@flea.home \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=icenowy@aosc.xyz \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).