From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-pm@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Leo Yan <leo.yan@linaro.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: cpuidle: Support asymmetric idle definition
Date: Mon, 12 Jun 2017 21:17:45 +0200 [thread overview]
Message-ID: <20170612191745.GF2261@mai> (raw)
In-Reply-To: <2056969.dMlCPX6XND@aspire.rjw.lan>
On Mon, Jun 12, 2017 at 08:49:39PM +0200, Rafael J. Wysocki wrote:
> On Monday, June 12, 2017 05:55:10 PM Daniel Lezcano wrote:
> > Some hardware have clusters with different idle states. The current code does
> > not support this and fails as it expects all the idle states to be identical.
> >
> > Because of this, the Mediatek mtk8173 had to create the same idle state for a
> > big.Little system and now the Hisilicon 960 is facing the same situation.
> >
> > Solve this by simply assuming the multiple driver will be needed for all the
> > platforms using the ARM generic cpuidle driver which makes sense because of the
> > different topologies we can support with a single kernel for ARM32 or ARM64.
> >
> > Every CPU has its own driver, so every single CPU can specify in the DT the
> > idle states.
> >
> > This simple approach allows to support the future dynamIQ system, current SMP
> > and HMP.
> >
> > Tested on:
> > - 96boards: Hikey 620
> > - 96boards: Hikey 960
> > - 96boards: dragonboard410c
> > - Mediatek 8173
> >
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > Tested-by: Leo Yan <leo.yan@linaro.org>
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> There seems to have been quite some discussion regarding this one and I'm not
> sure about the resolution of it.
>
> I'd feel more comfortable with an ACK or Reviewed-by from Sudeep or Lorenzo here.
I understand.
Sudeep it is ok with the patch [1] without an explicit acked-by.
-- Daniel
[1] https://www.spinics.net/lists/kernel/msg2525980.html
next prev parent reply other threads:[~2017-06-12 19:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170612155441.GE2261@mai>
2017-06-12 15:55 ` [PATCH 1/2] cpuidle: dt: Add missing 'of_node_put()' Daniel Lezcano
2017-06-12 15:55 ` [PATCH 2/2] ARM: cpuidle: Support asymmetric idle definition Daniel Lezcano
2017-06-12 18:49 ` Rafael J. Wysocki
2017-06-12 19:17 ` Daniel Lezcano [this message]
2017-06-22 12:25 ` Daniel Lezcano
2017-06-22 14:27 ` Rafael J. Wysocki
2017-06-13 9:46 ` Sudeep Holla
2017-06-12 16:42 ` [PATCH 1/2] cpuidle: dt: Add missing 'of_node_put()' Lorenzo Pieralisi
2017-06-12 18:46 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170612191745.GF2261@mai \
--to=daniel.lezcano@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).