linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: magnus.damm@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] via-rhine: add support for changing MTU
Date: Tue, 13 Jun 2017 17:33:18 -0400 (EDT)	[thread overview]
Message-ID: <20170613.173318.167061176274123943.davem@davemloft.net> (raw)
In-Reply-To: <149737430797.28477.9215445312169809396.sendpatchset@little-apple>

From: Magnus Damm <magnus.damm@gmail.com>
Date: Wed, 14 Jun 2017 02:18:27 +0900

> From: Magnus Damm <damm+renesas@opensource.se>
> 
> Allow adjusting the MTU for via-rhine devices in case of no TX alignment
> buffer is used.
> 
> Lightly tested on ALIX2D13 hardware by making use of VXLAN with MTU set
> to 1500 on top of via-rhine devices with 1550 MTU. Without this patch
> the VXLAN MTU is limited to less than 1500.
> 
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>

Why is the TX alignment buffer such an obstacle?

It would be so much nicer if this could be supported for all chip
variants instead of some certain subset which users have no idea
of figuring out.  It's a really bad user experience to set them
up for failure like this.

  reply	other threads:[~2017-06-13 21:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 17:18 [PATCH] via-rhine: add support for changing MTU Magnus Damm
2017-06-13 21:33 ` David Miller [this message]
2017-06-14  6:02   ` Magnus Damm
2017-06-14 16:29     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170613.173318.167061176274123943.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).