Re: [PATCH v7 10/10] staging: fsl-mc: move bus driver out of staging

From: Greg KH <gregkh@linuxfoundation.org>
To: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc: "stuyoder@gmail.com" <stuyoder@gmail.com>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
	Stuart Yoder <stuart.yoder@nxp.com>,
	Roy Pledge <roy.pledge@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"agraf@suse.de" <agraf@suse.de>,
	Catalin Horghidan <catalin.horghidan@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Thomas Gleixner <tglx@linutronix.de>, Leo Li <leoyang.li@nxp.com>,
	Bharat Bhushan <bharat.bhushan@nxp.com>,
	Jason Cooper <jason@lakedaemon.net>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 10/10] staging: fsl-mc: move bus driver out of staging
Date: Wed, 14 Jun 2017 15:48:26 +0200	[thread overview]
Message-ID: <20170614134826.GA24245@kroah.com> (raw)
In-Reply-To: <59413C3A.1010306@nxp.com>

On Wed, Jun 14, 2017 at 01:38:04PM +0000, Laurentiu Tudor wrote:
> Hi Greg,
> 
> On 06/13/2017 01:22 PM, Greg KH wrote:
> > On Thu, Jun 08, 2017 at 05:28:55PM +0300, laurentiu.tudor@nxp.com wrote:
> >> From: Stuart Yoder <stuart.yoder@nxp.com>
> >>
> >> Move the source files out of staging into their final locations:
> >>    -include files in drivers/staging/fsl-mc/include go to include/linux/fsl
> >>    -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
> >
> > Why do you have so many different .h files?  You should only need 1
> > "external" one, and one "internal" one, right?  Can you please work on
> > cleaning that up first?
> >
> 
> So here's the list of headers, for quick reference.
> 
> dpbp.h
> dpcon-cmd.h
> dpmng.h
> dprc.h
> mc-bus.h
> mc-cmd.h
> mc-sys.h
> mc.h
> 
> And here's a proposal on how to reorganize them:
> 
>   - dpbp.h (together with dbbp.c) be left behind in staging as they are
>     not used by the bus itself but by the drivers probing on this bus.
>     They will be moved out of staging at a later time.
>   - same for dpcon-cmd.h. Will handle it when we'll start work on
>     getting dpcon.c & dpcon.h out of staging.
>   - dprc.h contains APIs for handling mc-bus "device containers" that are
>     managed by the mc-bus driver itself. I'd leave this as is, but i
>     think i can make it private.
>   - regarding the multiple mc*.h files, i'll see what it takes to
>     refactor them in a mc-bus.h + mc-bus-private.h
>   - dpmng.h merged in the public header
> 
> Regarding the future plans for dpbp.h and dpcon.h, these expose common 
> APIs used throughout all the drivers, so i think it makes sense to leave 
> them as they are and, when their time comes, move them in the public 
> include/linux/fsl.

Ok, that sounds like a good start, let's see how that goes...