From: Michal Hocko <mhocko@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/4] mm, hugetlb: unclutter hugetlb allocation layers
Date: Wed, 14 Jun 2017 16:04:50 +0200 [thread overview]
Message-ID: <20170614140450.GQ6045@dhcp22.suse.cz> (raw)
In-Reply-To: <20170614134258.GP6045@dhcp22.suse.cz>
On Wed 14-06-17 15:42:58, Michal Hocko wrote:
> On Wed 14-06-17 15:18:26, Vlastimil Babka wrote:
> > On 06/13/2017 11:00 AM, Michal Hocko wrote:
> [...]
> > > @@ -1717,13 +1640,22 @@ struct page *alloc_huge_page_node(struct hstate *h, int nid)
> > > page = dequeue_huge_page_node(h, nid);
> > > spin_unlock(&hugetlb_lock);
> > >
> > > - if (!page)
> > > - page = __alloc_buddy_huge_page_no_mpol(h, nid);
> > > + if (!page) {
> > > + nodemask_t nmask;
> > > +
> > > + if (nid != NUMA_NO_NODE) {
> > > + nmask = NODE_MASK_NONE;
> > > + node_set(nid, nmask);
> >
> > TBH I don't like this hack too much, and would rather see __GFP_THISNODE
> > involved, which picks a different (short) zonelist. Also it's allocating
> > nodemask on stack, which we generally avoid? Although the callers
> > currently seem to be shallow.
>
> Fair enough. That would require pulling gfp mask handling up the call
> chain. This on top of this patch + refreshes for other patches later in
> the series as they will conflict now?
I've rebase the attempts/hugetlb-zonelists branch for an easier review.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-06-14 14:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 9:00 [RFC PATCH 0/4] mm, hugetlb: allow proper node fallback dequeue Michal Hocko
2017-06-13 9:00 ` [RFC PATCH 1/4] mm, hugetlb: unclutter hugetlb allocation layers Michal Hocko
2017-06-14 13:18 ` Vlastimil Babka
2017-06-14 13:42 ` Michal Hocko
2017-06-14 14:04 ` Michal Hocko [this message]
2017-06-14 15:06 ` Vlastimil Babka
2017-06-14 15:28 ` Michal Hocko
2017-06-13 9:00 ` [RFC PATCH 2/4] hugetlb: add support for preferred node to alloc_huge_page_nodemask Michal Hocko
2017-06-14 16:17 ` Vlastimil Babka
2017-06-14 16:41 ` Michal Hocko
2017-06-14 16:57 ` Vlastimil Babka
2017-06-14 22:12 ` Mike Kravetz
2017-06-15 0:12 ` Mike Kravetz
2017-06-15 8:12 ` Michal Hocko
2017-06-13 9:00 ` [RFC PATCH 3/4] mm, hugetlb: get rid of dequeue_huge_page_node Michal Hocko
2017-06-13 9:00 ` [RFC PATCH 4/4] mm, hugetlb, soft_offline: use new_page_nodemask for soft offline migration Michal Hocko
2017-06-14 16:22 ` Vlastimil Babka
2017-06-16 11:44 ` [RFC PATCH 0/4] mm, hugetlb: allow proper node fallback dequeue Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614140450.GQ6045@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).