From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752303AbdFNPcg (ORCPT ); Wed, 14 Jun 2017 11:32:36 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34441 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbdFNPce (ORCPT ); Wed, 14 Jun 2017 11:32:34 -0400 Date: Wed, 14 Jun 2017 10:32:32 -0500 From: Rob Herring To: Mark Yao Cc: David Airlie , Mark Rutland , Heiko Stuebner , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support Message-ID: <20170614153232.wbaa37zn24uusqlx@rob-hp-laptop> References: <1496992228-10582-1-git-send-email-mark.yao@rock-chips.com> <1496992236-10634-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496992236-10634-1-git-send-email-mark.yao@rock-chips.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 09, 2017 at 03:10:36PM +0800, Mark Yao wrote: > RK3399 and RK3288 shared the same HDMI IP controller, only some light > difference with GRF configure. > > Signed-off-by: Yakir Yang > Signed-off-by: Mark Yao > --- > Changes in v3: > remove hdmi_phy_configure_dwc_hdmi_3d_tx callbak. > > Changes in v2: > reuse hdmi_phy_configure_dwc_hdmi_3d_tx for phy configure > fixup Documentation > > .../bindings/display/rockchip/dw_hdmi-rockchip.txt | 3 +- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 67 ++++++++++++++++++---- > 2 files changed, 58 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt > index 046076c..495bcf5 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt > @@ -11,7 +11,8 @@ following device-specific properties. > > Required properties: > > -- compatible: Shall contain "rockchip,rk3288-dw-hdmi". > +- compatible: "rockchip,rk3288-dw-hdmi", > + "rockchip,rk3399-dw-hdmi"; Is this supposed to be "one of" or both? Please format it as 1 valid combination per line. Drop the ',' and the ';' because I see that as dts syntax. > - reg: See dw_hdmi.txt. > - reg-io-width: See dw_hdmi.txt. Shall be 4. > - interrupts: HDMI interrupt number