From: Alan Tull <atull@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Moritz Fischer <moritz.fischer@ettus.com>,
Alan Tull <atull@kernel.org>,
linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org,
Joshua Clayton <stillcompiling@gmail.com>
Subject: [PATCH v2 08/11] fpga-manager: altera-ps-spi: use bitrev8x4
Date: Wed, 14 Jun 2017 10:36:32 -0500 [thread overview]
Message-ID: <20170614153635.2763-9-atull@kernel.org> (raw)
In-Reply-To: <20170614153635.2763-1-atull@kernel.org>
From: Joshua Clayton <stillcompiling@gmail.com>
Speed up bit reversal by using hardware bit reversal
Add extra code to handle less than 4byte remnants, if any
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
Signed-off-by: Alan Tull <atull@kernel.org>
---
drivers/fpga/altera-ps-spi.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
index 0db8def..14f14ef 100644
--- a/drivers/fpga/altera-ps-spi.c
+++ b/drivers/fpga/altera-ps-spi.c
@@ -149,12 +149,23 @@ static int altera_ps_write_init(struct fpga_manager *mgr,
static void rev_buf(char *buf, size_t len)
{
- const char *fw_end = (buf + len);
+ u32 *fw32 = (u32 *)buf;
+ size_t extra_bytes = (len & 0x03);
+ const u32 *fw_end = (u32 *)(buf + len - extra_bytes);
/* set buffer to lsb first */
- while (buf < fw_end) {
- *buf = bitrev8(*buf);
- buf++;
+ while (fw32 < fw_end) {
+ *fw32 = bitrev8x4(*fw32);
+ fw32++;
+ }
+
+ if (extra_bytes) {
+ buf = (char *)fw_end;
+ while (extra_bytes) {
+ *buf = bitrev8(*buf);
+ buf++;
+ extra_bytes--;
+ }
}
}
--
2.7.4
next prev parent reply other threads:[~2017-06-14 15:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 15:36 [PATCH v2 00/11] patches for fpga Alan Tull
2017-06-14 15:36 ` [PATCH v2 01/11] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler Alan Tull
2017-06-14 15:36 ` [PATCH v2 02/11] Make FPGA a menuconfig to ease disabling it all Alan Tull
2017-06-14 15:36 ` [PATCH v2 03/11] fpga: Add flag to indicate SPI bitstream is bit-reversed Alan Tull
2017-06-14 15:36 ` [PATCH v2 04/11] doc: dt: document altera-passive-serial binding Alan Tull
2017-06-14 15:36 ` [PATCH v2 05/11] fpga manager: Add altera-ps-spi driver for Altera FPGAs Alan Tull
2017-06-14 15:36 ` [PATCH v2 06/11] ARM: dts: imx6q-evi: support altera-ps-spi Alan Tull
2017-06-14 15:36 ` [PATCH v2 07/11] lib: add bitrev8x4() Alan Tull
2017-06-14 15:36 ` Alan Tull [this message]
2017-06-14 15:36 ` [PATCH v2 09/11] of: Add vendor prefix for Lattice Semiconductor Alan Tull
2017-06-14 15:36 ` [PATCH v2 10/11] fpga: Add flag to indicate bitstream needs decompression Alan Tull
2017-06-14 15:36 ` [PATCH v2 11/11] fpga manager: Add Altera CvP driver Alan Tull
2017-07-04 9:03 ` [PATCH v2 00/11] patches for fpga Anatolij Gustschin
2017-07-04 9:12 ` Greg Kroah-Hartman
2017-07-04 9:30 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170614153635.2763-9-atull@kernel.org \
--to=atull@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=stillcompiling@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).