From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753047AbdFOPCF (ORCPT ); Thu, 15 Jun 2017 11:02:05 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:54066 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752683AbdFOPCE (ORCPT ); Thu, 15 Jun 2017 11:02:04 -0400 Date: Thu, 15 Jun 2017 11:02:02 -0400 (EDT) Message-Id: <20170615.110202.2304410513992498772.davem@davemloft.net> To: herbert@gondor.apana.org.au Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: Crypto Fixes for 4.12 From: David Miller In-Reply-To: <20170615094210.GA32322@gondor.apana.org.au> References: <20170615005443.GA30435@gondor.apana.org.au> <20170615094210.GA32322@gondor.apana.org.au> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 15 Jun 2017 07:20:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Herbert Xu Date: Thu, 15 Jun 2017 17:42:10 +0800 > On Thu, Jun 15, 2017 at 06:04:44PM +0900, Linus Torvalds wrote: >> There's a fair number of SHASH_DESC_ON_STACK users, are all the others >> safe for some random reason that just happens to be about code >> generation? Did people actually verify that? > > If I understand this correctly this is only an issue if you directly > return a value from the shash_desc struct allocated on the stack. > This is usually rare as normally you'd return an error code and the > hash result would be written directly to some memory passed in from > the caller. Correct.