From: Baoquan He <bhe@redhat.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
keescook@chromium.org, x86@kernel.org, fanc.fnst@cn.fujitsu.com,
caoj.fnst@cn.fujitsu.com, douly.fnst@cn.fujitsu.com
Subject: Re: [PATCH 2/2] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions if existed
Date: Thu, 15 Jun 2017 23:03:10 +0800 [thread overview]
Message-ID: <20170615150310.GD16181@x1> (raw)
In-Reply-To: <201706152200.8tTQydxV%fengguang.wu@intel.com>
On 06/15/17 at 10:04pm, kbuild test robot wrote:
> Hi Baoquan,
>
> [auto build test WARNING on tip/auto-latest]
> [also build test WARNING on next-20170615]
> [cannot apply to tip/x86/core v4.12-rc5]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Baoquan-He/x86-boot-KASLR-Restrict-kernel-to-be-randomized-in-mirror-regions-if-existed/20170615-204125
> config: i386-defconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All warnings (new ones prefixed by >>):
>
> arch/x86/boot/compressed/kaslr.c: In function 'process_efi_entry':
> >> arch/x86/boot/compressed/kaslr.c:604:24: warning: 'return' with a value, in function returning void
> return -EINVAL;
> ^
> arch/x86/boot/compressed/kaslr.c:566:13: note: declared here
> static void process_efi_entry(unsigned long minimum, unsigned long image_size)
> ^~~~~~~~~~~~~~~~~
>
> vim +/return +604 arch/x86/boot/compressed/kaslr.c
>
> 588
> 589 /*
> 590 * Mirrored regions are meaningful only if "kernelcore=mirror"
> 591 * specified.
> 592 */
> 593 str = strstr(cmdline, "kernelcore=");
> 594 if (!str)
> 595 return;
> 596 str += strlen("kernelcore=");
> 597 if (strncmp(str, "mirror", 6))
> 598 return;
> 599
> 600 #ifdef CONFIG_X86_32
> 601 /* Can't handle data above 4GB at this time */
> 602 if (e->efi_memmap_hi) {
> 603 warn("Memory map is above 4GB, disabling EFI.\n");
> > 604 return -EINVAL;
Yeah, this need be changed. This patchset is not a formal one, there was
unclear issue. Now it has been clarified, will repost a formal one after
test on efi mirror machine passed.
> 605 }
> 606 pmap = e->efi_memmap;
> 607 #else
> 608 pmap = (e->efi_memmap | ((__u64)e->efi_memmap_hi << 32));
> 609 #endif
> 610
> 611 nr_desc = e->efi_memmap_size / e->efi_memdesc_size;
> 612 for (i = 0; i < nr_desc; i++) {
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2017-06-15 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 7:52 [RFC][PATCH 0/2] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions if existed Baoquan He
2017-06-15 7:52 ` [PATCH 1/2] x86/boot/KASLR: Adapt process_e820_entry for all kinds of memory map Baoquan He
2017-06-20 8:22 ` Chao Fan
2017-06-15 7:52 ` [PATCH 2/2] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions if existed Baoquan He
2017-06-15 14:04 ` kbuild test robot
2017-06-15 15:03 ` Baoquan He [this message]
2017-06-15 8:03 ` [RFC][PATCH 0/2] " Baoquan He
2017-06-15 8:34 ` Izumi, Taku
2017-06-15 9:20 ` 'Baoquan He'
2017-06-22 3:10 ` Chao Fan
2017-06-22 3:20 ` Baoquan He
2017-06-22 3:36 ` Chao Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170615150310.GD16181@x1 \
--to=bhe@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=kbuild-all@01.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).