Re: [PATCH] objtool: Add fortify_panic as __noreturn function

From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Daniel Micay <danielmicay@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
	linux-kernel@vger.kernel.org,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] objtool: Add fortify_panic as __noreturn function
Date: Thu, 15 Jun 2017 15:07:51 +1000	[thread overview]
Message-ID: <20170615150751.7c5dbc04@canb.auug.org.au> (raw)
In-Reply-To: <1497502161.1435.9.camel@gmail.com>

Hi Daniel,

On Thu, 15 Jun 2017 00:49:21 -0400 Daniel Micay <danielmicay@gmail.com> wrote:
>
> > So after that the errors (x86_64 allmodconfig build) are only:
> > 
> > In file included from include/linux/bitmap.h:8:0,
> >                  from include/linux/cpumask.h:11,
> >                  from arch/x86/include/asm/cpumask.h:4,
> >                  from arch/x86/include/asm/msr.h:10,
> >                  from arch/x86/include/asm/processor.h:20,
> >                  from arch/x86/include/asm/cpufeature.h:4,
> >                  from arch/x86/include/asm/thread_info.h:52,
> >                  from include/linux/thread_info.h:37,
> >                  from arch/x86/include/asm/preempt.h:6,
> >                  from include/linux/preempt.h:80,
> >                  from include/linux/spinlock.h:50,
> >                  from include/linux/mmzone.h:7,
> >                  from include/linux/gfp.h:5,
> >                  from arch/x86/power/hibernate_64.c:11:
> > In function 'memcpy',
> >     inlined from 'relocate_restore_code' at
> > arch/x86/power/hibernate_64.c:150:2,
> >     inlined from 'swsusp_arch_resume' at
> > arch/x86/power/hibernate_64.c:186:8:
> > include/linux/string.h:309:4: error: call to '__read_overflow2'
> > declared with attribute error: detected read beyond size of object
> > passed as 2nd parameter
> >     __read_overflow2();
> >     ^
> > In file included from include/linux/bitmap.h:8:0,
> >                  from include/linux/cpumask.h:11,
> >                  from arch/x86/include/asm/cpumask.h:4,
> >                  from arch/x86/include/asm/msr.h:10,
> >                  from arch/x86/include/asm/processor.h:20,
> >                  from arch/x86/include/asm/cpufeature.h:4,
> >                  from arch/x86/include/asm/thread_info.h:52,
> >                  from include/linux/thread_info.h:37,
> >                  from arch/x86/include/asm/preempt.h:6,
> >                  from include/linux/preempt.h:80,
> >                  from include/linux/spinlock.h:50,
> >                  from include/linux/mmzone.h:7,
> >                  from include/linux/gfp.h:5,
> >                  from include/linux/mm.h:9,
> >                  from kernel/kexec_file.c:15:
> > In function 'memcmp',
> >     inlined from 'kexec_load_purgatory' at kernel/kexec_file.c:900:6:
> > include/linux/string.h:348:4: error: call to '__read_overflow'
> > declared with attribute error: detected read beyond size of object
> > passed as 1st parameter
> >     __read_overflow();
> >     ^
> >   
> 
> Kees has the remaining ones here now:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/kspp

Excellent, so hopefully tomorrow I won't need to revert (at which point
the overnight builds (http://kisskb.ellerman.id.au/linux-next) will
point out any more problems).

> Not entirely sure what happened to the powerpc bits though.

Maybe in the powerpc tree
(git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git#next).

-- 
Cheers,
Stephen Rothwell