From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Guenter Roeck <private@roeck-us.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: hexagon: build error in -next due to 'mm: memcontrol: per-lruvec stats infrastructure'
Date: Fri, 16 Jun 2017 13:37:21 -0700 [thread overview]
Message-ID: <20170616133721.0087401e2c00613b5a253b42@linux-foundation.org> (raw)
In-Reply-To: <20170616201523.GA11016@cmpxchg.org>
On Fri, 16 Jun 2017 16:15:23 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> In any case, memcontrol.h doesn't/shouldn't need hardirq.h. When that
> include is removed, the below patch compiles on: x86 allno, x86_64
> allno, and my regular x86_64 config:
>
> ---
> Subject: mm-memcontrol-per-lruvec-stats-infrastructure-fix-4
Did you try x86_64 allmodconfig? I'm getting a mess:
In file included from ./include/linux/mm.h:1032,
from ./include/linux/highmem.h:7,
from ./include/linux/bio.h:21,
from ./include/linux/writeback.h:205,
from ./include/linux/memcontrol.h:28,
from ./include/linux/swap.h:8,
from ./include/linux/suspend.h:4,
from arch/x86/kernel/asm-offsets.c:12:
./include/linux/vmstat.h: In function 'lruvec_page_state':
./include/linux/vmstat.h:362: error: implicit declaration of function 'mem_cgroup_disabled'
./include/linux/vmstat.h:365: error: dereferencing pointer to incomplete type
./include/linux/vmstat.h:365: error: type defaults to 'int' in declaration of 'type name'
...
Presumably because we have memcontrol.h indirectly including mm.h which
includes vmstat.h (from a stupid place) and with this patch we have
vmstat.h including memcontrol.h.
next prev parent reply other threads:[~2017-06-16 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 7:26 hexagon: build error in -next due to 'mm: memcontrol: per-lruvec stats infrastructure' Guenter Roeck
2017-06-16 18:49 ` Johannes Weiner
2017-06-16 19:14 ` Andrew Morton
2017-06-16 20:15 ` Johannes Weiner
2017-06-16 20:37 ` Andrew Morton [this message]
2017-06-17 18:11 ` mm-memcontrol-per-lruvec-stats-infrastructure-fix-4 kbuild test robot
2017-06-17 18:28 ` mm-memcontrol-per-lruvec-stats-infrastructure-fix-4 kbuild test robot
2017-06-17 15:37 hexagon: build error in -next due to 'mm: memcontrol: per-lruvec stats infrastructure' Guenter Roeck
2017-06-19 15:47 ` Johannes Weiner
2017-06-17 15:40 Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170616133721.0087401e2c00613b5a253b42@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=private@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).