linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* hexagon: build error in -next due to 'mm: memcontrol: per-lruvec stats infrastructure'
@ 2017-06-14  7:26 Guenter Roeck
  2017-06-16 18:49 ` Johannes Weiner
  0 siblings, 1 reply; 10+ messages in thread
From: Guenter Roeck @ 2017-06-14  7:26 UTC (permalink / raw)
  To: Johannes Weiner, linux-kernel, Andrew Morton

Hi,

I see the following build error in -next when building hexagon images.

   CC      arch/hexagon/kernel/asm-offsets.s
In file included from ./include/linux/memcontrol.h:30:0,
                  from ./include/linux/swap.h:8,
                  from ./arch/hexagon/include/asm/pgtable.h:27,
                  from ./include/linux/mm.h:70,
                  from arch/hexagon/kernel/asm-offsets.c:28:
./include/linux/vmstat.h: In function '__inc_zone_page_state':
./include/linux/vmstat.h:294:2: error: implicit declaration of function 'page_zone' [-Werror=implicit-function-declaration]
./include/linux/vmstat.h:294:2: warning: passing argument 1 of '__inc_zone_state' makes pointer from integer without a cast [enabled by default]
./include/linux/vmstat.h:267:20: note: expected 'struct zone *' but argument is of type 'int'
./include/linux/vmstat.h: In function '__inc_node_page_state':
./include/linux/vmstat.h:300:2: error: implicit declaration of function 'page_pgdat' [-Werror=implicit-function-declaration]
./include/linux/vmstat.h:300:2: warning: passing argument 1 of '__inc_node_state' makes pointer from integer without a cast [enabled by default]
./include/linux/vmstat.h:273:20: note: expected 'struct pglist_data *' but argument is of type 'int'
./include/linux/vmstat.h: In function '__dec_zone_page_state':
./include/linux/vmstat.h:307:2: warning: passing argument 1 of '__dec_zone_state' makes pointer from integer without a cast [enabled by default]
./include/linux/vmstat.h:279:20: note: expected 'struct zone *' but argument is of type 'int'
./include/linux/vmstat.h: In function '__dec_node_page_state':
./include/linux/vmstat.h:313:2: warning: passing argument 1 of '__dec_node_state' makes pointer from integer without a cast [enabled by default]
./include/linux/vmstat.h:285:20: note: expected 'struct pglist_data *' but argument is of type 'int'

Bisect points to 'mm: memcontrol: per-lruvec stats infrastructure'. Bisect log is attached.

Guenter

---

# bad: [b14746170b0684005bab3e07893e6b91baf7dbf6] Add linux-next specific files for 20170614
# good: [32c1431eea4881a6b17bd7c639315010aeefa452] Linux 4.12-rc5
git bisect start 'HEAD' 'v4.12-rc5'
# good: [0500b956eedb4686b0420308ae01a74b00f9ab64] Merge remote-tracking branch 'crypto/master'
git bisect good 0500b956eedb4686b0420308ae01a74b00f9ab64
# good: [4717c17660509cee9d3596eb19b99f3e26d57c36] Merge remote-tracking branch 'tip/auto-latest'
git bisect good 4717c17660509cee9d3596eb19b99f3e26d57c36
# good: [ad001607f386be7fc1f4353c550e7cf14ac7026c] Merge remote-tracking branch 'slave-dma/next'
git bisect good ad001607f386be7fc1f4353c550e7cf14ac7026c
# good: [0222e195b36f0ae047f728d68f9c2310c1b310e0] Merge remote-tracking branch 'gpio/for-next'
git bisect good 0222e195b36f0ae047f728d68f9c2310c1b310e0
# bad: [ed151d2581a7ed2bcd6cd13e0f7a6980356b0990] ipc: merge ipc_rcu and kern_ipc_perm
git bisect bad ed151d2581a7ed2bcd6cd13e0f7a6980356b0990
# good: [68fd987c837e601ae322ce812968b20d9b0e63d0] mm/oom_kill: count global and memory cgroup oom kills
git bisect good 68fd987c837e601ae322ce812968b20d9b0e63d0
# bad: [d931ca9904caddd5aeca14d8bc89365774075971] sh64: ascii armor the sh64 boot init stack canary
git bisect bad d931ca9904caddd5aeca14d8bc89365774075971
# bad: [7c54a485ad62b9b1c04f1104650bcf6be7fdaf2c] mm: hugetlb: soft-offline: dissolve source hugepage after successful migration
git bisect bad 7c54a485ad62b9b1c04f1104650bcf6be7fdaf2c
# bad: [90cca56e4ed5a8e707dba7bcecd5e72d9f45cd9f] mm: memcontrol: per-lruvec stats infrastructure fix 3
git bisect bad 90cca56e4ed5a8e707dba7bcecd5e72d9f45cd9f
# good: [d955b3fb9e7fb6dfca433d482187636ba2c3938b] mm/zswap.c: delete an error message for a failed memory allocation in zswap_dstmem_prepare()
git bisect good d955b3fb9e7fb6dfca433d482187636ba2c3938b
# good: [9a2176b1242f1f31c4136ac85cfcb0348851ad20] mm: memcontrol: use generic mod_memcg_page_state for kmem pages
git bisect good 9a2176b1242f1f31c4136ac85cfcb0348851ad20
# bad: [5eeb97bbd4d67c49b9bf3108b72b909dd7c6b5ce] mm-memcontrol-per-lruvec-stats-infrastructure-fix
git bisect bad 5eeb97bbd4d67c49b9bf3108b72b909dd7c6b5ce
# bad: [fb6646f52c459b87ecd033521bc6fd0a7640d334] mm: memcontrol: per-lruvec stats infrastructure
git bisect bad fb6646f52c459b87ecd033521bc6fd0a7640d334
# first bad commit: [fb6646f52c459b87ecd033521bc6fd0a7640d334] mm: memcontrol: per-lruvec stats infrastructure

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: hexagon: build error in -next due to 'mm: memcontrol: per-lruvec stats infrastructure'
@ 2017-06-17 15:37 Guenter Roeck
  2017-06-19 15:47 ` Johannes Weiner
  0 siblings, 1 reply; 10+ messages in thread
From: Guenter Roeck @ 2017-06-17 15:37 UTC (permalink / raw)
  To: Johannes Weiner; +Cc: Guenter Roeck, linux-kernel

On Fri, Jun 16, 2017 at 01:37:21PM -0700,  wrote:
> On Fri, 16 Jun 2017 16:15:23 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> 
> > In any case, memcontrol.h doesn't/shouldn't need hardirq.h. When that
> > include is removed, the below patch compiles on: x86 allno, x86_64
> > allno, and my regular x86_64 config:
> > 
> > ---
> > Subject: mm-memcontrol-per-lruvec-stats-infrastructure-fix-4
> 
> Did you try x86_64 allmodconfig?  I'm getting a mess:
> 
> In file included from ./include/linux/mm.h:1032,
>                  from ./include/linux/highmem.h:7,
>                  from ./include/linux/bio.h:21,
>                  from ./include/linux/writeback.h:205,
>                  from ./include/linux/memcontrol.h:28,
>                  from ./include/linux/swap.h:8,
>                  from ./include/linux/suspend.h:4,
>                  from arch/x86/kernel/asm-offsets.c:12:
> ./include/linux/vmstat.h: In function 'lruvec_page_state':
> ./include/linux/vmstat.h:362: error: implicit declaration of function 'mem_cgroup_disabled'
> ./include/linux/vmstat.h:365: error: dereferencing pointer to incomplete type
> ./include/linux/vmstat.h:365: error: type defaults to 'int' in declaration of 'type name'
> ...
> 
> Presumably because we have memcontrol.h indirectly including mm.h which
> includes vmstat.h (from a stupid place) and with this patch we have
> vmstat.h including memcontrol.h.
> 

How about the following ? Seems to be less invasive, and it fixes the
immediate problem.

Guenter

---
>From 3aa278a36b5f71ff64b28e0cea05182fbcaa72e6 Mon Sep 17 00:00:00 2001
From: Guenter Roeck <linux@roeck-us.net>
Date: Sat, 17 Jun 2017 08:15:57 -0700
Subject: [PATCH] hexagon: Fix build error caused by include file order

hexagon builds fail with the following error message.
In file included from ./include/linux/memcontrol.h:30:0,
                 from ./include/linux/swap.h:8,
		 from ./arch/hexagon/include/asm/pgtable.h:27,
		from ./include/linux/mm.h:70,
		from arch/hexagon/kernel/asm-offsets.c:28:
./include/linux/vmstat.h: In function '__inc_zone_page_state':
./include/linux/vmstat.h:294:2: error:
	implicit declaration of function 'page_zone'

Drop unnecessary includes from header files and add missing
includes to source files to fix the problem.

Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Fixes: fb6646f52c45 ("mm: memcontrol: per-lruvec stats infrastructure")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/hexagon/include/asm/pgtable.h | 1 -
 arch/hexagon/kernel/asm-offsets.c  | 1 -
 arch/hexagon/mm/vm_tlb.c           | 1 +
 3 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/hexagon/include/asm/pgtable.h b/arch/hexagon/include/asm/pgtable.h
index 24a9177fb897..aef02f7ca8aa 100644
--- a/arch/hexagon/include/asm/pgtable.h
+++ b/arch/hexagon/include/asm/pgtable.h
@@ -24,7 +24,6 @@
 /*
  * Page table definitions for Qualcomm Hexagon processor.
  */
-#include <linux/swap.h>
 #include <asm/page.h>
 #define __ARCH_USE_5LEVEL_HACK
 #include <asm-generic/pgtable-nopmd.h>
diff --git a/arch/hexagon/kernel/asm-offsets.c b/arch/hexagon/kernel/asm-offsets.c
index 308be68d4fb3..3980c0407aa1 100644
--- a/arch/hexagon/kernel/asm-offsets.c
+++ b/arch/hexagon/kernel/asm-offsets.c
@@ -25,7 +25,6 @@
 #include <linux/compat.h>
 #include <linux/types.h>
 #include <linux/sched.h>
-#include <linux/mm.h>
 #include <linux/interrupt.h>
 #include <linux/kbuild.h>
 #include <asm/ptrace.h>
diff --git a/arch/hexagon/mm/vm_tlb.c b/arch/hexagon/mm/vm_tlb.c
index 9647d00cb761..b474065533ce 100644
--- a/arch/hexagon/mm/vm_tlb.c
+++ b/arch/hexagon/mm/vm_tlb.c
@@ -24,6 +24,7 @@
  * be instantiated for it, differently from a native build.
  */
 #include <linux/mm.h>
+#include <linux/sched.h>
 #include <asm/page.h>
 #include <asm/hexagon_vm.h>
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: hexagon: build error in -next due to 'mm: memcontrol: per-lruvec stats infrastructure'
@ 2017-06-17 15:40 Guenter Roeck
  0 siblings, 0 replies; 10+ messages in thread
From: Guenter Roeck @ 2017-06-17 15:40 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Johannes Weiner, Guenter Roeck, linux-kernel

[resending; somehow Andrew got lost in my first reply]

On Fri, Jun 16, 2017 at 01:37:21PM -0700, Andrew Morton wrote:
> On Fri, 16 Jun 2017 16:15:23 -0400 Johannes Weiner <hannes@cmpxchg.org> wrote:
> 
> > In any case, memcontrol.h doesn't/shouldn't need hardirq.h. When that
> > include is removed, the below patch compiles on: x86 allno, x86_64
> > allno, and my regular x86_64 config:
> > 
> > ---
> > Subject: mm-memcontrol-per-lruvec-stats-infrastructure-fix-4
> 
> Did you try x86_64 allmodconfig?  I'm getting a mess:
> 
> In file included from ./include/linux/mm.h:1032,
>                  from ./include/linux/highmem.h:7,
>                  from ./include/linux/bio.h:21,
>                  from ./include/linux/writeback.h:205,
>                  from ./include/linux/memcontrol.h:28,
>                  from ./include/linux/swap.h:8,
>                  from ./include/linux/suspend.h:4,
>                  from arch/x86/kernel/asm-offsets.c:12:
> ./include/linux/vmstat.h: In function 'lruvec_page_state':
> ./include/linux/vmstat.h:362: error: implicit declaration of function 'mem_cgroup_disabled'
> ./include/linux/vmstat.h:365: error: dereferencing pointer to incomplete type
> ./include/linux/vmstat.h:365: error: type defaults to 'int' in declaration of 'type name'
> ...
> 
> Presumably because we have memcontrol.h indirectly including mm.h which
> includes vmstat.h (from a stupid place) and with this patch we have
> vmstat.h including memcontrol.h.
> 

How about the following ? Seems to be less invasive, and it fixes the
immediate problem.

Guenter

---
>From 3aa278a36b5f71ff64b28e0cea05182fbcaa72e6 Mon Sep 17 00:00:00 2001
From: Guenter Roeck <linux@roeck-us.net>
Date: Sat, 17 Jun 2017 08:15:57 -0700
Subject: [PATCH] hexagon: Fix build error caused by include file order

hexagon builds fail with the following error message.
In file included from ./include/linux/memcontrol.h:30:0,
                 from ./include/linux/swap.h:8,
		 from ./arch/hexagon/include/asm/pgtable.h:27,
		from ./include/linux/mm.h:70,
		from arch/hexagon/kernel/asm-offsets.c:28:
./include/linux/vmstat.h: In function '__inc_zone_page_state':
./include/linux/vmstat.h:294:2: error:
	implicit declaration of function 'page_zone'

Drop unnecessary includes from header files and add missing
includes to source files to fix the problem.

Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Fixes: fb6646f52c45 ("mm: memcontrol: per-lruvec stats infrastructure")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/hexagon/include/asm/pgtable.h | 1 -
 arch/hexagon/kernel/asm-offsets.c  | 1 -
 arch/hexagon/mm/vm_tlb.c           | 1 +
 3 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/hexagon/include/asm/pgtable.h b/arch/hexagon/include/asm/pgtable.h
index 24a9177fb897..aef02f7ca8aa 100644
--- a/arch/hexagon/include/asm/pgtable.h
+++ b/arch/hexagon/include/asm/pgtable.h
@@ -24,7 +24,6 @@
 /*
  * Page table definitions for Qualcomm Hexagon processor.
  */
-#include <linux/swap.h>
 #include <asm/page.h>
 #define __ARCH_USE_5LEVEL_HACK
 #include <asm-generic/pgtable-nopmd.h>
diff --git a/arch/hexagon/kernel/asm-offsets.c b/arch/hexagon/kernel/asm-offsets.c
index 308be68d4fb3..3980c0407aa1 100644
--- a/arch/hexagon/kernel/asm-offsets.c
+++ b/arch/hexagon/kernel/asm-offsets.c
@@ -25,7 +25,6 @@
 #include <linux/compat.h>
 #include <linux/types.h>
 #include <linux/sched.h>
-#include <linux/mm.h>
 #include <linux/interrupt.h>
 #include <linux/kbuild.h>
 #include <asm/ptrace.h>
diff --git a/arch/hexagon/mm/vm_tlb.c b/arch/hexagon/mm/vm_tlb.c
index 9647d00cb761..b474065533ce 100644
--- a/arch/hexagon/mm/vm_tlb.c
+++ b/arch/hexagon/mm/vm_tlb.c
@@ -24,6 +24,7 @@
  * be instantiated for it, differently from a native build.
  */
 #include <linux/mm.h>
+#include <linux/sched.h>
 #include <asm/page.h>
 #include <asm/hexagon_vm.h>
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2017-06-19 15:47 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-14  7:26 hexagon: build error in -next due to 'mm: memcontrol: per-lruvec stats infrastructure' Guenter Roeck
2017-06-16 18:49 ` Johannes Weiner
2017-06-16 19:14   ` Andrew Morton
2017-06-16 20:15     ` Johannes Weiner
2017-06-16 20:37       ` Andrew Morton
2017-06-17 18:11       ` mm-memcontrol-per-lruvec-stats-infrastructure-fix-4 kbuild test robot
2017-06-17 18:28       ` mm-memcontrol-per-lruvec-stats-infrastructure-fix-4 kbuild test robot
2017-06-17 15:37 hexagon: build error in -next due to 'mm: memcontrol: per-lruvec stats infrastructure' Guenter Roeck
2017-06-19 15:47 ` Johannes Weiner
2017-06-17 15:40 Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).