From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752804AbdFRAZG (ORCPT ); Sat, 17 Jun 2017 20:25:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36900 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbdFRAZF (ORCPT ); Sat, 17 Jun 2017 20:25:05 -0400 Date: Sat, 17 Jun 2017 21:27:04 +0200 From: Greg Kroah-Hartman To: Dmitry Torokhov Cc: linux-kernel@vger.kernel.org, Guenter Roeck Subject: Re: [PATCH 2/2] sysfs: add devm_sysfs_create_group() and friends Message-ID: <20170617192704.GE2974@kroah.com> References: <20170213003619.4083-1-dmitry.torokhov@gmail.com> <20170213003619.4083-2-dmitry.torokhov@gmail.com> <20170327175359.GA23215@dtor-ws> <20170327193544.GB30423@kroah.com> <20170607170445.GC13116@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170607170445.GC13116@dtor-ws> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 07, 2017 at 10:04:45AM -0700, Dmitry Torokhov wrote: > On Mon, Mar 27, 2017 at 09:35:45PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Mar 27, 2017 at 10:53:59AM -0700, Dmitry Torokhov wrote: > > > On Sun, Feb 12, 2017 at 04:36:19PM -0800, Dmitry Torokhov wrote: > > > > Many drivers create additional driver-specific device attributes when > > > > binding to the device and providing managed version of sysfs_create_group() > > > > will simplify unbinding and error handling in probe path for such drivers. > > > > > > > > Without managed version driver writers either have to mix manual and > > > > managed resources, which is prone to errors, or open-code this function by > > > > providing a wrapper to sysfs_create_group() and use it with > > > > devm_add_action() or devm_add_action_or_reset(). > > > > > > > > Signed-off-by: Dmitry Torokhov > > > > --- > > > > > > Greg, gentle ping... > > > > It's not lost, it's in my queue... > > Another gentle ping... Ugh, I've been hoping you would forget about this :) But, in thinking a lot about this recently, I have now come to the same conclusion as you, I think we really need this as there isn't a way to handle it any other way. So, can you rebase and resend these patches? I don't have them in my queue anymore and I'd like to play with them and see how they work. thanks, greg k-h