From: "Pali Rohár" <pali.rohar@gmail.com>
To: Mario.Limonciello@dell.com
Cc: luto@kernel.org, platform-driver-x86@vger.kernel.org,
andriy.shevchenko@linux.intel.com, luto@amacapital.net,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded Binary WMI MOF metadata
Date: Mon, 19 Jun 2017 18:19:36 +0200 [thread overview]
Message-ID: <201706191819.37016@pali> (raw)
In-Reply-To: <074e9d5668864a81b255df178ed28814@ausx13mpc120.AMER.DELL.COM>
[-- Attachment #1: Type: Text/Plain, Size: 2961 bytes --]
On Monday 19 June 2017 18:13:13 Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Pali Rohár [mailto:pali.rohar@gmail.com]
> > Sent: Monday, June 19, 2017 11:08 AM
> > To: Andy Lutomirski <luto@kernel.org>
> > Cc: platform-driver-x86@vger.kernel.org; Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com>; Andy Lutomirski
> > <luto@amacapital.net>; Limonciello, Mario
> > <Mario_Limonciello@Dell.com>; Rafael Wysocki <rjw@rjwysocki.net>;
> > linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org Subject:
> > Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose
> > embedded Binary WMI MOF metadata
> >
> > On Tuesday 06 June 2017 05:16:44 Andy Lutomirski wrote:
> > > Many laptops (and maybe servers?) have embedded WMI Binary MOF
> > > metadata. We do not yet have open-source tools for processing the
> > >
> > > data, although one is in the works thanks to Pali:
> > > https://github.com/pali/bmfdec
> > >
> > > There is currently no interface to get the data in the first
> > > place. By exposing it, we facilitate the development of new
> > > tools.
> > >
> > > Signed-off-by: Andy Lutomirski <luto@kernel.org>
> > > Cc: Andy Lutomirski <luto@amacapital.net>
> > > Cc: Mario Limonciello <mario_limonciello@dell.com>
> > > Cc: Pali Rohár <pali.rohar@gmail.com>
> > > Cc: linux-kernel@vger.kernel.org
> > > Cc: platform-driver-x86@vger.kernel.org
> > > Cc: linux-acpi@vger.kernel.org
> > > [dvhart: make sysfs mof binary read only, fixup comment block
> > > format] [dvhart: use bmof terminology and dev_err instead of
> > > dev_warn] Acked-by: Rafael J. Wysocki
> > > <rafael.j.wysocki@intel.com> Signed-off-by: Darren Hart (VMware)
> > > <dvhart@infradead.org> ---
> > >
> > > since-v1:
> > > * address Pali's comments:
> > > * update the cover letter for clarity and accuracy
> > > * update mof->bmof and MOF to Binary MOF throughout the patch
> > > * use dev_err instead of dev_warn in wmi_bmof_probe
> > >
> > > drivers/platform/x86/Kconfig | 12 ++++
> > > drivers/platform/x86/Makefile | 1 +
> > > drivers/platform/x86/wmi-bmof.c | 125
> >
> > Another suggestion (unrelated to this patch): For working with
> > ACPI-WMI, this binary MOF buffer is not enough. It is needed also
> > content of _WDG buffer. What about exporting it too via sysfs?
> > Probably not part of of wmi-bmof driver, but wmi driver itself.
>
> I think this depends upon how the userspace access to WMI methods
> gets implemented, no? If userpsace access to WMI methods show up as
> /dev/wmi-$GUID-$INSTANCE and those internally to the kernel map to
> the proper ASL methods for example, what you get from wmi-bmof
> should be enough shouldn't it?
Ok. Such interface for userspace application could be enough.
But for debugging purposes or writing new WMI driver it is needed to
have both _WDG + BMOF.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2017-06-19 16:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 3:16 [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded Binary WMI MOF metadata Andy Lutomirski
2017-06-06 9:30 ` Andy Shevchenko
2017-06-06 16:34 ` Darren Hart
2017-06-06 16:54 ` Darren Hart
2017-06-06 18:45 ` Andy Shevchenko
2017-06-06 10:04 ` Pali Rohár
2017-06-06 17:02 ` Darren Hart
2017-06-06 20:50 ` Pali Rohár
2017-07-04 13:28 ` Pali Rohár
2017-11-23 14:39 ` Pali Rohár
2017-11-23 14:48 ` Andy Lutomirski
2017-06-06 22:31 ` Andy Lutomirski
2017-06-06 23:35 ` kbuild test robot
2017-06-19 16:07 ` Pali Rohár
2017-06-19 16:13 ` Mario.Limonciello
2017-06-19 16:19 ` Pali Rohár [this message]
2017-06-19 16:23 ` Andy Lutomirski
2017-06-20 12:12 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201706191819.37016@pali \
--to=pali.rohar@gmail.com \
--cc=Mario.Limonciello@dell.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).